Skip to content

Commit 973712b

Browse files
kocsismatekocsismate
committed
Improve parameter handling in ext/openssl
1 parent 1fb66b8 commit 973712b

20 files changed

+311
-337
lines changed

‎ext/openssl/openssl.c

Lines changed: 47 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -865,7 +865,7 @@ static int php_openssl_parse_config(struct php_x509_request * req, zval * option
865865
zend_long cipher_algo = Z_LVAL_P(item);
866866
const EVP_CIPHER* cipher = php_openssl_get_evp_cipher_from_algo(cipher_algo);
867867
if (cipher == NULL) {
868-
php_error_docref(NULL, E_WARNING, "Unknown cipher algorithm for private key");
868+
php_error_docref(NULL, E_WARNING, "Unknown cipher method for private key");
869869
return FAILURE;
870870
} else {
871871
req->priv_key_encrypt_cipher = cipher;
@@ -1563,7 +1563,7 @@ PHP_FUNCTION(openssl_spki_new)
15631563
mdtype = php_openssl_get_evp_md_from_algo(algo);
15641564

15651565
if (!mdtype) {
1566-
php_error_docref(NULL, E_WARNING, "Unknown signature algorithm");
1566+
php_error_docref(NULL, E_WARNING, "Unknown digest method");
15671567
goto cleanup;
15681568
}
15691569

@@ -1589,7 +1589,7 @@ PHP_FUNCTION(openssl_spki_new)
15891589

15901590
if (!NETSCAPE_SPKI_sign(spki, pkey, mdtype)) {
15911591
php_openssl_store_errors();
1592-
php_error_docref(NULL, E_WARNING, "Unable to sign with specified algorithm");
1592+
php_error_docref(NULL, E_WARNING, "Unable to sign with specified digest method");
15931593
goto cleanup;
15941594
}
15951595

@@ -1845,7 +1845,7 @@ zend_string* php_openssl_x509_fingerprint(X509 *peer, const char *method, zend_b
18451845
zend_string *ret;
18461846

18471847
if (!(mdtype = EVP_get_digestbyname(method))) {
1848-
php_error_docref(NULL, E_WARNING, "Unknown signature algorithm");
1848+
php_error_docref(NULL, E_WARNING, "Unknown hashing algorithm");
18491849
return NULL;
18501850
} else if (!X509_digest(peer, mdtype, md, &n)) {
18511851
php_openssl_store_errors();
@@ -3753,7 +3753,7 @@ static EVP_PKEY * php_openssl_generate_private_key(struct php_x509_request * req
37533753
{
37543754
EC_KEY *eckey;
37553755
if (req->curve_name == NID_undef) {
3756-
php_error_docref(NULL, E_WARNING, "Missing configuration value: 'curve_name' not set");
3756+
php_error_docref(NULL, E_WARNING, "Missing configuration value: \"curve_name\" not set");
37573757
return NULL;
37583758
}
37593759
eckey = EC_KEY_new_by_curve_name(req->curve_name);
@@ -4465,11 +4465,13 @@ PHP_FUNCTION(openssl_pkey_get_private)
44654465
size_t passphrase_len = sizeof("")-1;
44664466
php_openssl_pkey_object *key_object;
44674467

4468-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "z|s", &cert, &passphrase, &passphrase_len) == FAILURE) {
4468+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "z|s!", &cert, &passphrase, &passphrase_len) == FAILURE) {
44694469
RETURN_THROWS();
44704470
}
44714471

4472-
PHP_OPENSSL_CHECK_SIZE_T_TO_INT(passphrase_len, passphrase, 2);
4472+
if (passphrase) {
4473+
PHP_OPENSSL_CHECK_SIZE_T_TO_INT(passphrase_len, passphrase, 2);
4474+
}
44734475

44744476
pkey = php_openssl_pkey_from_zval(cert, 0, passphrase, passphrase_len);
44754477
if (pkey == NULL) {
@@ -4847,7 +4849,7 @@ PHP_FUNCTION(openssl_pkcs7_verify)
48474849

48484850
RETVAL_LONG(-1);
48494851

4850-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "pl|pappp", &filename, &filename_len,
4852+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "pl|p!a!p!p!p!", &filename, &filename_len,
48514853
&flags, &signersfilename, &signersfilename_len, &cainfo,
48524854
&extracerts, &extracerts_len, &datafilename, &datafilename_len, &p7bfilename, &p7bfilename_len) == FAILURE) {
48534855
RETURN_THROWS();
@@ -6082,7 +6084,7 @@ PHP_FUNCTION(openssl_cms_decrypt)
60826084
Z_PARAM_PATH(outfilename, outfilename_len)
60836085
Z_PARAM_ZVAL(recipcert)
60846086
Z_PARAM_OPTIONAL
6085-
Z_PARAM_ZVAL(recipkey)
6087+
Z_PARAM_ZVAL_OR_NULL(recipkey)
60866088
Z_PARAM_LONG(encoding)
60876089
ZEND_PARSE_PARAMETERS_END();
60886090

@@ -6128,8 +6130,7 @@ PHP_FUNCTION(openssl_cms_decrypt)
61286130
cms = SMIME_read_CMS(in, &datain);
61296131
break;
61306132
default:
6131-
php_error_docref(NULL, E_WARNING,
6132-
"Unknown OPENSSL encoding");
6133+
zend_argument_value_error(5, "must be an OPENSSL_ENCODING_* constant");
61336134
goto clean_exit;
61346135
}
61356136

@@ -6456,13 +6457,18 @@ PHP_FUNCTION(openssl_sign)
64566457
char * data;
64576458
size_t data_len;
64586459
EVP_MD_CTX *md_ctx;
6459-
zval *method = NULL;
6460-
zend_long signature_algo = OPENSSL_ALGO_SHA1;
6460+
zend_string *method_str = NULL;
6461+
zend_long method_long = OPENSSL_ALGO_SHA1;
64616462
const EVP_MD *mdtype;
64626463

6463-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "szz|z", &data, &data_len, &signature, &key, &method) == FAILURE) {
6464-
RETURN_THROWS();
6465-
}
6464+
ZEND_PARSE_PARAMETERS_START(3, 4)
6465+
Z_PARAM_STRING(data, data_len)
6466+
Z_PARAM_ZVAL(signature)
6467+
Z_PARAM_ZVAL(key)
6468+
Z_PARAM_OPTIONAL
6469+
Z_PARAM_STR_OR_LONG(method_str, method_long)
6470+
ZEND_PARSE_PARAMETERS_END();
6471+
64666472
pkey = php_openssl_pkey_from_zval(key, 0, "", 0);
64676473
if (pkey == NULL) {
64686474
if (!EG(exception)) {
@@ -6471,17 +6477,10 @@ PHP_FUNCTION(openssl_sign)
64716477
RETURN_FALSE;
64726478
}
64736479

6474-
if (method == NULL || Z_TYPE_P(method) == IS_LONG) {
6475-
if (method != NULL) {
6476-
signature_algo = Z_LVAL_P(method);
6477-
}
6478-
mdtype = php_openssl_get_evp_md_from_algo(signature_algo);
6479-
} else if (Z_TYPE_P(method) == IS_STRING) {
6480-
mdtype = EVP_get_digestbyname(Z_STRVAL_P(method));
6480+
if (method_str) {
6481+
mdtype = EVP_get_digestbyname(ZSTR_VAL(method_str));
64816482
} else {
6482-
// TODO Use proper ZPP check.
6483-
zend_argument_type_error(4, "must be of type string|int|null, %s given" , zend_zval_type_name(method));
6484-
RETURN_THROWS();
6483+
mdtype = php_openssl_get_evp_md_from_algo(method_long);
64856484
}
64866485
if (!mdtype) {
64876486
php_error_docref(NULL, E_WARNING, "Unknown signature algorithm");
@@ -6522,26 +6521,23 @@ PHP_FUNCTION(openssl_verify)
65226521
size_t data_len;
65236522
char * signature;
65246523
size_t signature_len;
6525-
zval *method = NULL;
6526-
zend_long signature_algo = OPENSSL_ALGO_SHA1;
6524+
zend_string *method_str = NULL;
6525+
zend_long method_long = OPENSSL_ALGO_SHA1;
65276526

6528-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "ssz|z", &data, &data_len, &signature, &signature_len, &key, &method) == FAILURE) {
6529-
RETURN_THROWS();
6530-
}
6527+
ZEND_PARSE_PARAMETERS_START(3, 4)
6528+
Z_PARAM_STRING(data, data_len)
6529+
Z_PARAM_STRING(signature, signature_len)
6530+
Z_PARAM_ZVAL(key)
6531+
Z_PARAM_OPTIONAL
6532+
Z_PARAM_STR_OR_LONG(method_str, method_long)
6533+
ZEND_PARSE_PARAMETERS_END();
65316534

65326535
PHP_OPENSSL_CHECK_SIZE_T_TO_UINT(signature_len, signature, 2);
65336536

6534-
if (method == NULL || Z_TYPE_P(method) == IS_LONG) {
6535-
if (method != NULL) {
6536-
signature_algo = Z_LVAL_P(method);
6537-
}
6538-
mdtype = php_openssl_get_evp_md_from_algo(signature_algo);
6539-
} else if (Z_TYPE_P(method) == IS_STRING) {
6540-
mdtype = EVP_get_digestbyname(Z_STRVAL_P(method));
6537+
if (method_str) {
6538+
mdtype = EVP_get_digestbyname(ZSTR_VAL(method_str));
65416539
} else {
6542-
// TODO Use proper ZPP check.
6543-
zend_argument_type_error(4, "must be of type string|int|null, %s given" , zend_zval_type_name(method));
6544-
RETURN_THROWS();
6540+
mdtype = php_openssl_get_evp_md_from_algo(method_long);
65456541
}
65466542
if (!mdtype) {
65476543
php_error_docref(NULL, E_WARNING, "Unknown signature algorithm");
@@ -6584,7 +6580,7 @@ PHP_FUNCTION(openssl_seal)
65846580
const EVP_CIPHER *cipher;
65856581
EVP_CIPHER_CTX *ctx;
65866582

6587-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "szza|sz", &data, &data_len,
6583+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "szza|s!z", &data, &data_len,
65886584
&sealdata, &ekeys, &pubkeys, &method, &method_len, &iv) == FAILURE) {
65896585
RETURN_THROWS();
65906586
}
@@ -6610,7 +6606,7 @@ PHP_FUNCTION(openssl_seal)
66106606

66116607
iv_len = EVP_CIPHER_iv_length(cipher);
66126608
if (!iv && iv_len > 0) {
6613-
zend_argument_value_error(6, "must provide an IV for chosen cipher algorithm");
6609+
zend_argument_value_error(6, "cannot be null for the chosen cipher method");
66146610
RETURN_THROWS();
66156611
}
66166612

@@ -6715,7 +6711,7 @@ PHP_FUNCTION(openssl_open)
67156711
size_t method_len = 0, iv_len = 0;
67166712
const EVP_CIPHER *cipher;
67176713

6718-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "szsz|ss", &data, &data_len, &opendata,
6714+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "szsz|s!s!", &data, &data_len, &opendata,
67196715
&ekey, &ekey_len, &privkey, &method, &method_len, &iv, &iv_len) == FAILURE) {
67206716
RETURN_THROWS();
67216717
}
@@ -6734,7 +6730,7 @@ PHP_FUNCTION(openssl_open)
67346730
if (method) {
67356731
cipher = EVP_get_cipherbyname(method);
67366732
if (!cipher) {
6737-
php_error_docref(NULL, E_WARNING, "Unknown signature algorithm");
6733+
php_error_docref(NULL, E_WARNING, "Unknown cipher method");
67386734
RETURN_FALSE;
67396735
}
67406736
} else {
@@ -6744,7 +6740,7 @@ PHP_FUNCTION(openssl_open)
67446740
cipher_iv_len = EVP_CIPHER_iv_length(cipher);
67456741
if (cipher_iv_len > 0) {
67466742
if (!iv) {
6747-
zend_argument_value_error(6, "must provide an IV for chosen cipher algorithm");
6743+
zend_argument_value_error(6, "cannot be null for the chosen cipher method");
67486744
RETURN_THROWS();
67496745
}
67506746
if ((size_t)cipher_iv_len != iv_len) {
@@ -6866,7 +6862,7 @@ PHP_FUNCTION(openssl_digest)
68666862
}
68676863
mdtype = EVP_get_digestbyname(method);
68686864
if (!mdtype) {
6869-
php_error_docref(NULL, E_WARNING, "Unknown signature algorithm");
6865+
php_error_docref(NULL, E_WARNING, "Unknown digest method");
68706866
RETURN_FALSE;
68716867
}
68726868

@@ -7126,7 +7122,7 @@ PHP_OPENSSL_API zend_string* php_openssl_encrypt(
71267122

71277123
cipher_type = EVP_get_cipherbyname(method);
71287124
if (!cipher_type) {
7129-
php_error_docref(NULL, E_WARNING, "Unknown cipher algorithm");
7125+
php_error_docref(NULL, E_WARNING, "Unknown cipher method");
71307126
return NULL;
71317127
}
71327128

@@ -7242,7 +7238,7 @@ PHP_OPENSSL_API zend_string* php_openssl_decrypt(
72427238

72437239
cipher_type = EVP_get_cipherbyname(method);
72447240
if (!cipher_type) {
7245-
php_error_docref(NULL, E_WARNING, "Unknown cipher algorithm");
7241+
php_error_docref(NULL, E_WARNING, "Unknown cipher method");
72467242
return NULL;
72477243
}
72487244

@@ -7304,7 +7300,7 @@ PHP_FUNCTION(openssl_decrypt)
73047300
size_t data_len, method_len, password_len, iv_len = 0, tag_len = 0, aad_len = 0;
73057301
zend_string *ret;
73067302

7307-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "sss|lsss", &data, &data_len, &method, &method_len,
7303+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "sss|lss!s", &data, &data_len, &method, &method_len,
73087304
&password, &password_len, &options, &iv, &iv_len, &tag, &tag_len, &aad, &aad_len) == FAILURE) {
73097305
RETURN_THROWS();
73107306
}
@@ -7328,7 +7324,7 @@ PHP_OPENSSL_API zend_long php_openssl_cipher_iv_length(const char *method)
73287324

73297325
cipher_type = EVP_get_cipherbyname(method);
73307326
if (!cipher_type) {
7331-
php_error_docref(NULL, E_WARNING, "Unknown cipher algorithm");
7327+
php_error_docref(NULL, E_WARNING, "Unknown cipher method");
73327328
return -1;
73337329
}
73347330

0 commit comments

Comments
 (0)