Skip to content

Commit 97cdf62

Browse files
committed
Merge branch 'PHP-8.1'
* PHP-8.1: Fix the value param of SimpleXMLElement::addAttribute()
2 parents 5d6bc25 + 713dcb2 commit 97cdf62

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ext/simplexml/simplexml.stub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function __construct(string $data, int $options = 0, bool $dataIsURL = fa
4444
public function addChild(string $qualifiedName, ?string $value = null, ?string $namespace = null): ?SimpleXMLElement {}
4545

4646
/** @tentative-return-type */
47-
public function addAttribute(string $qualifiedName, ?string $value = null, ?string $namespace = null): void {}
47+
public function addAttribute(string $qualifiedName, string $value, ?string $namespace = null): void {}
4848

4949
/** @tentative-return-type */
5050
public function getName(): string {}

ext/simplexml/simplexml_arginfo.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: 46da4d24787a5f975eebeaab3872eb29273a9625 */
2+
* Stub hash: 06c88dc2fb5582a6d21c11aee6ac0a0538e70cbc */
33

44
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_simplexml_load_file, 0, 1, SimpleXMLElement, MAY_BE_FALSE)
55
ZEND_ARG_TYPE_INFO(0, filename, IS_STRING, 0)
@@ -67,9 +67,9 @@ ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_OBJ_INFO_EX(arginfo_class_SimpleXMLElement_
6767
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, namespace, IS_STRING, 1, "null")
6868
ZEND_END_ARG_INFO()
6969

70-
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(arginfo_class_SimpleXMLElement_addAttribute, 0, 1, IS_VOID, 0)
70+
ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(arginfo_class_SimpleXMLElement_addAttribute, 0, 2, IS_VOID, 0)
7171
ZEND_ARG_TYPE_INFO(0, qualifiedName, IS_STRING, 0)
72-
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, value, IS_STRING, 1, "null")
72+
ZEND_ARG_TYPE_INFO(0, value, IS_STRING, 0)
7373
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, namespace, IS_STRING, 1, "null")
7474
ZEND_END_ARG_INFO()
7575

0 commit comments

Comments
 (0)