Another review

Author: kocsismate

ext/date/php_date.c

@@ -4193,7 +4193,7 @@ PHP_METHOD(DatePeriod, __construct)
 	}
 
 	if (dpobj->end == NULL && recurrences < 1) {
-		zend_argument_error(zend_ce_exception, 3, "must be greater than 0");
+		zend_throw_error(zend_ce_exception, "Recurrence count must be greater than 0");
 		RETURN_THROWS();
 	}
 

ext/date/tests/DatePeriod_wrong_recurrence_on_constructor.phpt

@@ -9,11 +9,12 @@ try {
 }
 
 try {
-    new DatePeriod(new DateTime('yesterday'), new DateInterval('P1D'),-1);
+    new DatePeriod(new DateTime('yesterday'), new DateInterval('P1D'), -1);
 } catch (Exception $exception) {
     echo $exception->getMessage(), "\n";
 }
+
 ?>
 --EXPECT--
-DatePeriod::__construct(): Argument #3 ($end) must be greater than 0
-DatePeriod::__construct(): Argument #3 ($end) must be greater than 0
+DatePeriod::__construct(): Recurrence count must be greater than 0
+DatePeriod::__construct(): Recurrence count must be greater than 0