Implement feedback

Author: iluuu1994

ext/reflection/php_reflection.c

@@ -7229,6 +7229,8 @@ ZEND_METHOD(ReflectionConstant, __construct)
 
 	intern->ptr = const_;
 	intern->ref_type = REF_TYPE_OTHER;
+
+	ZVAL_STR_COPY(reflection_prop_name(object), const_name);
 }
 
 ZEND_METHOD(ReflectionConstant, getName)

ext/reflection/php_reflection.stub.php

@@ -836,6 +836,8 @@ public function getTrace(int $options = DEBUG_BACKTRACE_PROVIDE_OBJECT): array {
  */
 final class ReflectionConstant
 {
+    public string $name;
+
     public function __construct(string $name) {}
 
     public function getName(): string {}

ext/reflection/php_reflection_arginfo.h

@@ -0,0 +1,33 @@
+--TEST--
+var_dump(ReflectionConstant)
+--EXTENSIONS--
+zend_test
+--FILE--
+<?php
+
+define('RT_CONST', 42);
+const CT_CONST = 43;
+
+var_dump(new ReflectionConstant('ZEND_CONSTANT_A'));
+var_dump(new ReflectionConstant('ZEND_TEST_DEPRECATED'));
+var_dump(new ReflectionConstant('RT_CONST'));
+var_dump(new ReflectionConstant('CT_CONST'));
+
+?>
+--EXPECT--
+object(ReflectionConstant)#1 (1) {
+  ["name"]=>
+  string(15) "ZEND_CONSTANT_A"
+}
+object(ReflectionConstant)#1 (1) {
+  ["name"]=>
+  string(20) "ZEND_TEST_DEPRECATED"
+}
+object(ReflectionConstant)#1 (1) {
+  ["name"]=>
+  string(8) "RT_CONST"
+}
+object(ReflectionConstant)#1 (1) {
+  ["name"]=>
+  string(8) "CT_CONST"
+}

ext/reflection/tests/ReflectionConstant_dump.phpt

@@ -15,8 +15,13 @@ define('RT_CONST', 42);
 $reflectionConstant = new ReflectionConstant('RT_CONST');
 var_dump($reflectionConstant->getName());
 
+define('CT_CONST', 43);
+$reflectionConstant = new ReflectionConstant('CT_CONST');
+var_dump($reflectionConstant->getName());
+
 ?>
 --EXPECT--
 string(15) "ZEND_CONSTANT_A"
 string(20) "ZEND_TEST_DEPRECATED"
 string(8) "RT_CONST"
+string(8) "CT_CONST"

ext/reflection/tests/ReflectionConstant_getName.phpt

@@ -15,8 +15,13 @@ define('RT_CONST', 42);
 $reflectionConstant = new ReflectionConstant('RT_CONST');
 var_dump($reflectionConstant->getValue());
 
+define('CT_CONST', 43);
+$reflectionConstant = new ReflectionConstant('CT_CONST');
+var_dump($reflectionConstant->getValue());
+
 ?>
 --EXPECT--
 string(6) "global"
 int(42)
 int(42)
+int(43)

ext/reflection/tests/ReflectionConstant_getValue.phpt

@@ -15,8 +15,13 @@ define('RT_CONST', 42);
 $reflectionConstant = new ReflectionConstant('RT_CONST');
 var_dump($reflectionConstant->isDeprecated());
 
+const CT_CONST = 43;
+$reflectionConstant = new ReflectionConstant('CT_CONST');
+var_dump($reflectionConstant->isDeprecated());
+
 ?>
 --EXPECT--
 bool(false)
 bool(true)
 bool(false)
+bool(false)