Skip to content

Commit ac8b7b8

Browse files
authored
Fix wrong comment and use cheaper destruction macro (#17359)
1 parent 7be3649 commit ac8b7b8

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ext/standard/user_filters.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -357,8 +357,8 @@ PHP_FUNCTION(stream_bucket_make_writeable)
357357
ZVAL_RES(&zbucket, zend_register_resource(bucket, le_bucket));
358358
object_init_ex(return_value, stream_bucket_class_entry);
359359
zend_update_property(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("bucket"), &zbucket);
360-
/* add_property_zval increments the refcount which is unwanted here */
361-
zval_ptr_dtor(&zbucket);
360+
/* zend_update_property increments the refcount which is unwanted here */
361+
Z_DELREF(zbucket);
362362
zend_update_property_stringl(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("data"), bucket->buf, bucket->buflen);
363363
zend_update_property_long(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("datalen"), bucket->buflen);
364364
zend_update_property_long(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("dataLength"), bucket->buflen);
@@ -461,8 +461,8 @@ PHP_FUNCTION(stream_bucket_new)
461461
ZVAL_RES(&zbucket, zend_register_resource(bucket, le_bucket));
462462
object_init_ex(return_value, stream_bucket_class_entry);
463463
zend_update_property(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("bucket"), &zbucket);
464-
/* add_property_zval increments the refcount which is unwanted here */
465-
zval_ptr_dtor(&zbucket);
464+
/* zend_update_property increments the refcount which is unwanted here */
465+
Z_DELREF(zbucket);
466466
zend_update_property_stringl(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("data"), bucket->buf, bucket->buflen);
467467
zend_update_property_long(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("datalen"), bucket->buflen);
468468
zend_update_property_long(Z_OBJCE_P(return_value), Z_OBJ_P(return_value), ZEND_STRL("dataLength"), bucket->buflen);

0 commit comments

Comments
 (0)