Skip to content

Commit af57b63

Browse files
committed
Reverting push to wrong repo
1 parent 5870efb commit af57b63

File tree

1 file changed

+6
-27
lines changed

1 file changed

+6
-27
lines changed

Zend/zend_alloc.c

Lines changed: 6 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -195,11 +195,6 @@ typedef struct _zend_mm_free_slot zend_mm_free_slot;
195195
typedef struct _zend_mm_chunk zend_mm_chunk;
196196
typedef struct _zend_mm_huge_list zend_mm_huge_list;
197197

198-
/*
199-
* 0 means disabled
200-
* 1 means huge pages
201-
* 2 means transparent huge pages
202-
*/
203198
int zend_mm_use_huge_pages = 0;
204199

205200
/*
@@ -234,13 +229,6 @@ int zend_mm_use_huge_pages = 0;
234229
* 2 for 5-8, 3 for 9-16 etc) see zend_alloc_sizes.h
235230
*/
236231

237-
/*
238-
* For environments where mmap is expensive it can be
239-
* worthwhile to avoid mmap/munmap churn by raising
240-
* the minimum number of chunks in emalloc
241-
*/
242-
int zend_mm_min_chunks = 0;
243-
244232
struct _zend_mm_heap {
245233
#if ZEND_MM_CUSTOM
246234
int use_custom_heap;
@@ -474,7 +462,7 @@ static void *zend_mm_mmap(size_t size)
474462
void *ptr;
475463

476464
#ifdef MAP_HUGETLB
477-
if (zend_mm_use_huge_pages == 1 && size == ZEND_MM_CHUNK_SIZE) {
465+
if (zend_mm_use_huge_pages && size == ZEND_MM_CHUNK_SIZE) {
478466
ptr = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANON | MAP_HUGETLB, -1, 0);
479467
if (ptr != MAP_FAILED) {
480468
return ptr;
@@ -681,7 +669,7 @@ static void *zend_mm_chunk_alloc_int(size_t size, size_t alignment)
681669
return NULL;
682670
} else if (ZEND_MM_ALIGNED_OFFSET(ptr, alignment) == 0) {
683671
#ifdef MADV_HUGEPAGE
684-
if (zend_mm_use_huge_pages == 2) {
672+
if (zend_mm_use_huge_pages) {
685673
madvise(ptr, size, MADV_HUGEPAGE);
686674
}
687675
#endif
@@ -714,7 +702,7 @@ static void *zend_mm_chunk_alloc_int(size_t size, size_t alignment)
714702
zend_mm_munmap((char*)ptr + size, alignment - REAL_PAGE_SIZE);
715703
}
716704
# ifdef MADV_HUGEPAGE
717-
if (zend_mm_use_huge_pages == 2) {
705+
if (zend_mm_use_huge_pages) {
718706
madvise(ptr, size, MADV_HUGEPAGE);
719707
}
720708
# endif
@@ -2282,15 +2270,14 @@ void zend_mm_shutdown(zend_mm_heap *heap, int full, int silent)
22822270
zend_mm_chunk_free(heap, heap->main_chunk, ZEND_MM_CHUNK_SIZE);
22832271
} else {
22842272
/* free some cached chunks to keep average count */
2285-
heap->avg_chunks_count = MAX((heap->avg_chunks_count + (double)heap->peak_chunks_count) / 2.0, zend_mm_min_chunks);
2273+
heap->avg_chunks_count = (heap->avg_chunks_count + (double)heap->peak_chunks_count) / 2.0;
22862274
while ((double)heap->cached_chunks_count + 0.9 > heap->avg_chunks_count &&
22872275
heap->cached_chunks) {
22882276
p = heap->cached_chunks;
22892277
heap->cached_chunks = p->next;
22902278
zend_mm_chunk_free(heap, p, ZEND_MM_CHUNK_SIZE);
22912279
heap->cached_chunks_count--;
22922280
}
2293-
22942281
/* clear cached chunks */
22952282
p = heap->cached_chunks;
22962283
while (p != NULL) {
@@ -2772,16 +2759,8 @@ static void alloc_globals_ctor(zend_alloc_globals *alloc_globals)
27722759
#endif
27732760

27742761
tmp = getenv("USE_ZEND_ALLOC_HUGE_PAGES");
2775-
if (tmp) {
2776-
zend_mm_use_huge_pages = zend_atoi(tmp, 0);
2777-
if (zend_mm_use_huge_pages > 2) {
2778-
zend_mm_use_huge_pages = 1;
2779-
}
2780-
}
2781-
2782-
tmp = getenv("USE_ZEND_MIN_CHUNKS");
2783-
if (tmp) {
2784-
zend_mm_min_chunks = zend_atoi(tmp, 0);
2762+
if (tmp && zend_atoi(tmp, 0)) {
2763+
zend_mm_use_huge_pages = 1;
27852764
}
27862765
alloc_globals->mm_heap = zend_mm_init();
27872766
}

0 commit comments

Comments
 (0)