Skip to content

Commit b124c0a

Browse files
committed
Drop todo comments in pdo_sql_parser.re
1 parent d3465b9 commit b124c0a

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

ext/pdo/pdo_sql_parser.re

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ PDO_API int pdo_parse_params(pdo_stmt_t *stmt, const char *inquery, size_t inque
151151
/* did the query make sense to me? */
152152
if (query_type == (PDO_PLACEHOLDER_NAMED|PDO_PLACEHOLDER_POSITIONAL)) {
153153
/* they mixed both types; punt */
154-
/* TODO Always Error */
155154
pdo_raise_impl_error(stmt->dbh, stmt, "HY093", "mixed named and positional parameters");
156155
ret = -1;
157156
goto clean_up;
@@ -193,7 +192,6 @@ PDO_API int pdo_parse_params(pdo_stmt_t *stmt, const char *inquery, size_t inque
193192
goto safe;
194193
}
195194
}
196-
/* TODO Error? */
197195
pdo_raise_impl_error(stmt->dbh, stmt, "HY093", "number of bound variables does not match number of tokens");
198196
ret = -1;
199197
goto clean_up;
@@ -224,7 +222,6 @@ safe:
224222
if (param == NULL) {
225223
/* parameter was not defined */
226224
ret = -1;
227-
/* TODO Error? */
228225
pdo_raise_impl_error(stmt->dbh, stmt, "HY093", "parameter was not defined");
229226
goto clean_up;
230227
}
@@ -260,7 +257,6 @@ safe:
260257
zend_string_release_ex(buf, 0);
261258
}
262259
} else {
263-
/* TODO Always TypeError */
264260
pdo_raise_impl_error(stmt->dbh, stmt, "HY105", "Expected a stream resource");
265261
ret = -1;
266262
goto clean_up;

0 commit comments

Comments
 (0)