Skip to content

Commit b273742

Browse files
committed
fixup! Migrate SOAP URL resource to object
1 parent 5430a0a commit b273742

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

UPGRADING

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,8 @@ PHP 8.4 UPGRADE NOTES
137137

138138
- SOAP:
139139
. SoapClient::$httpurl is now a Soap\Url object rather than a resource.
140-
Value checks using is_resource() should be replaced with checks for `null`.
140+
Checks using is_resource() (i.e. is_resource($soapClient->httpurl)) should
141+
be replaced with checks for null (i.e. $soapClient->httpurl !== null).
141142
. SoapClient::$sdl is now a Soap\Sdl object rather than a resource.
142143
Value checks using is_resource() should be replaced with checks for `null`.
143144

ext/soap/php_soap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ static zend_always_inline zval *php_soap_deref(zval *zv) {
253253
#define Z_CLIENT_LAST_REQUEST_HEADERS_P(zv) php_soap_deref(OBJ_PROP_NUM(Z_OBJ_P(zv), 34))
254254
#define Z_CLIENT_LAST_RESPONSE_HEADERS_P(zv) php_soap_deref(OBJ_PROP_NUM(Z_OBJ_P(zv), 35))
255255

256-
typedef struct {
256+
typedef struct soap_url_object {
257257
php_url *url;
258258
zend_object std;
259259
} soap_url_object;

0 commit comments

Comments
 (0)