Remove test for repeatable attributes

Author: kocsismate

ext/zend_test/test.c

@@ -37,9 +37,9 @@ ZEND_DECLARE_MODULE_GLOBALS(zend_test)
 static zend_class_entry *zend_test_interface;
 static zend_class_entry *zend_test_class;
 static zend_class_entry *zend_test_child_class;
+static zend_class_entry *zend_attribute_test_class;
 static zend_class_entry *zend_test_trait;
 static zend_class_entry *zend_test_attribute;
-static zend_class_entry *zend_test_repeatable_attribute;
 static zend_class_entry *zend_test_parameter_attribute;
 static zend_class_entry *zend_test_property_attribute;
 static zend_class_entry *zend_test_class_with_method_with_parameter_attribute;
@@ -727,6 +727,8 @@ PHP_MINIT_FUNCTION(zend_test)
 	memcpy(&zend_test_class_handlers, &std_object_handlers, sizeof(zend_object_handlers));
 	zend_test_class_handlers.get_method = zend_test_class_method_get;
 
+	zend_attribute_test_class = register_class_ZendAttributeTest();
+
 	zend_test_trait = register_class__ZendTestTrait();
 
 	register_test_symbols(module_number);
@@ -737,9 +739,6 @@ PHP_MINIT_FUNCTION(zend_test)
 		attr->validator = zend_attribute_validate_zendtestattribute;
 	}
 
-	zend_test_repeatable_attribute = register_class_ZendTestRepeatableAttribute();
-	zend_mark_internal_attribute(zend_test_repeatable_attribute);
-
 	zend_test_parameter_attribute = register_class_ZendTestParameterAttribute();
 	zend_mark_internal_attribute(zend_test_parameter_attribute);
 

ext/zend_test/test.stub.php

@@ -52,27 +52,28 @@ class _ZendTestChildClass extends _ZendTestClass
         public function returnsThrowable(): Exception {}
     }
 
-    trait _ZendTestTrait {
+    class ZendAttributeTest {
         /** @var int */
-        #[ZendTestRepeatableAttribute]
-        #[ZendTestRepeatableAttribute]
+        #[ZendTestAttribute]
         public const TEST_CONST = 1;
 
         /** @var mixed */
-        #[ZendTestRepeatableAttribute]
         #[ZendTestPropertyAttribute("testProp")]
         public $testProp;
 
         #[ZendTestAttribute]
         public function testMethod(): bool {}
     }
 
-    #[Attribute(Attribute::TARGET_ALL)]
-    final class ZendTestAttribute {
+    trait _ZendTestTrait {
+        /** @var mixed */
+        public $testProp;
+
+        public function testMethod(): bool {}
     }
 
-    #[Attribute(Attribute::TARGET_ALL|Attribute::IS_REPEATABLE)]
-    final class ZendTestRepeatableAttribute {
+    #[Attribute(Attribute::TARGET_ALL)]
+    final class ZendTestAttribute {
     }
 
     #[Attribute(Attribute::TARGET_PARAMETER)]

ext/zend_test/test_arginfo.h

@@ -5,28 +5,18 @@ zend_test
 --FILE--
 <?php
 
-class Foo {
-    use _ZendTestTrait;
-}
-
-$reflectionConstant = new ReflectionClassConstant(Foo::class, "TEST_CONST");
+$reflectionConstant = new ReflectionClassConstant(ZendAttributeTest::class, "TEST_CONST");
 var_dump($reflectionConstant->getAttributes()[0]->newInstance());
-var_dump($reflectionConstant->getAttributes()[1]->newInstance());
 
-$reflectionProperty = new ReflectionProperty(Foo::class, "testProp");
+$reflectionProperty = new ReflectionProperty(ZendAttributeTest::class, "testProp");
 var_dump($reflectionProperty->getAttributes()[0]->newInstance());
-var_dump($reflectionProperty->getAttributes()[1]->newInstance());
 
-$reflectionMethod = new ReflectionMethod(Foo::class, "testMethod");
+$reflectionMethod = new ReflectionMethod(ZendAttributeTest::class, "testMethod");
 var_dump($reflectionMethod->getAttributes()[0]->newInstance());
 
 ?>
 --EXPECTF--
-object(ZendTestRepeatableAttribute)#%d (%d) {
-}
-object(ZendTestRepeatableAttribute)#%d (%d) {
-}
-object(ZendTestRepeatableAttribute)#%d (%d) {
+object(ZendTestAttribute)#%d (%d) {
 }
 object(ZendTestPropertyAttribute)#%d (%d) {
   ["parameter"]=>