Skip to content

Commit b3bdc23

Browse files
committed
Remove unused Makefile variables FIBER_ASSEMBLER and FIBER_ASM_ARCH
In Windows build system these were replaced with common PHP_ASSEMBLER and FIBER_ASM_ABI when adjusting for the arm64. Closes GH-13263
1 parent 373237e commit b3bdc23

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

UPGRADING.INTERNALS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ PHP 8.4 INTERNALS UPGRADE NOTES
5959
system.
6060
- HAVE_WIN32_NATIVE_THREAD, USE_WIN32_NATIVE_THREAD, ENABLE_THREADS symbols
6161
in ext/mbstring/libmbfl removed.
62+
- FIBER_ASSEMBLER and FIBER_ASM_ARCH Makefile variables removed in favor of
63+
PHP_ASSEMBLER and FIBER_ASM_ABI.
6264

6365
========================
6466
3. Module changes

win32/build/config.w32

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -252,14 +252,6 @@ if (!PHP_ASSEMBLER) {
252252
ERROR("No assembler found, fiber cannot be built");
253253
}
254254
DEFINE('PHP_ASSEMBLER', PHP_ASSEMBLER);
255-
DEFINE('FIBER_ASSEMBLER', PHP_ASSEMBLER);// for compatible
256-
257-
var FIBER_ASM_ARCH = {
258-
'x64': 'x86_64',
259-
'x86': 'i386',
260-
'arm64': 'arm64'
261-
}[TARGET_ARCH];
262-
DEFINE('FIBER_ASM_ARCH', FIBER_ASM_ARCH); // for compatible only
263255

264256
var FIBER_ASM_ABI = {
265257
'x64': 'x86_64_ms_pe_masm',

0 commit comments

Comments
 (0)