change to raise a value error if an invalid value is passed to PDO::FB_TRANSACTION_ISOLATION_LEVEL.

Author: SakiTakamachi

ext/pdo_firebird/firebird_driver.c

@@ -1080,8 +1080,10 @@ static bool pdo_firebird_set_attribute(pdo_dbh_t *dbh, zend_long attr, zval *val
 						 */
 						H->txn_isolation_level = lval;
 					} else {
-						pdo_raise_impl_error(dbh, NULL, "HY000",
-							"Transaction isolation level must be PDO::FB_READ_COMMITTED, PDO::FB_REPEATABLE_READ, or PDO::PDO_FB_SERIALIZABLE");
+						zend_error_handling zeh;
+						zend_argument_value_error(2,
+							"PDO::FB_TRANSACTION_ISOLATION_LEVEL must be a valid transaction isolation level (PDO::FB_READ_COMMITTED, PDO::FB_REPEATABLE_READ, or PDO::FB_SERIALIZABLE)");
+						zend_restore_error_handling(&zeh);
 						return false;
 					}
 				}
@@ -1297,7 +1299,9 @@ static int pdo_firebird_handle_factory(pdo_dbh_t *dbh, zval *driver_options) /*
 	) {
 		H->txn_isolation_level = txn_isolation_level;
 	} else {
-		H->txn_isolation_level = PDO_FB_REPEATABLE_READ;
+		zend_argument_value_error(4,
+			"PDO::FB_TRANSACTION_ISOLATION_LEVEL must be a valid transaction isolation level (PDO::FB_READ_COMMITTED, PDO::FB_REPEATABLE_READ, or PDO::FB_SERIALIZABLE)");
+		ret = 0;
 	}
 
 	do {

ext/pdo_firebird/tests/transaction_isolation_level_attr.phpt

@@ -41,6 +41,22 @@ foreach ($levelStrs as $levelStr) {
     unset($dbh);
 }
 
+echo "Invalid value\n";
+try {
+    $dbh = new PDO(
+        PDO_FIREBIRD_TEST_DSN,
+        PDO_FIREBIRD_TEST_USER,
+        PDO_FIREBIRD_TEST_PASS,
+        [
+            PDO::FB_TRANSACTION_ISOLATION_LEVEL => PDO::ATTR_AUTOCOMMIT, // Invalid value
+        ],
+    );
+} catch (Throwable $e) {
+    echo $e->getMessage()."\n";
+}
+
+unset($dbh);
+
 echo "\n";
 echo "========== Set attr in setAttribute ==========\n";
 
@@ -62,13 +78,22 @@ foreach ($levelStrs as $levelStr) {
     }
 }
 
+echo "Invalid value\n";
+try {
+    $dbh->setAttribute(PDO::FB_TRANSACTION_ISOLATION_LEVEL, PDO::ATTR_AUTOCOMMIT); // Invalid value
+} catch (Throwable $e) {
+    echo $e->getMessage()."\n";
+}
+
 unset($dbh);
 ?>
 --EXPECT--
 ========== Set attr in construct ==========
 OK: PDO::FB_READ_COMMITTED
 OK: PDO::FB_REPEATABLE_READ
 OK: PDO::FB_SERIALIZABLE
+Invalid value
+PDO::__construct(): Argument #4 ($options) PDO::FB_TRANSACTION_ISOLATION_LEVEL must be a valid transaction isolation level (PDO::FB_READ_COMMITTED, PDO::FB_REPEATABLE_READ, or PDO::FB_SERIALIZABLE)
 
 ========== Set attr in setAttribute ==========
 bool(true)
@@ -77,3 +102,5 @@ bool(true)
 OK: PDO::FB_REPEATABLE_READ
 bool(true)
 OK: PDO::FB_SERIALIZABLE
+Invalid value
+PDO::setAttribute(): Argument #2 ($value) PDO::FB_TRANSACTION_ISOLATION_LEVEL must be a valid transaction isolation level (PDO::FB_READ_COMMITTED, PDO::FB_REPEATABLE_READ, or PDO::FB_SERIALIZABLE)