Slightly clarify zend_wrong_parameter_error() implementation

nikic · nikic · commit b9040852b34b · 2021-04-30T10:38:34.000+02:00
This function may be called with Z_ERROR_FAILURE, and should do
nothing in that case. Otherwise, all cases need to be explicitly
handled.
diff --git a/Zend/zend_API.c b/Zend/zend_API.c
@@ -242,8 +242,10 @@ ZEND_API ZEND_COLD void ZEND_FASTCALL zend_wrong_parameter_error(int error_code,
 		case ZPP_ERROR_UNEXPECTED_EXTRA_NAMED:
 			zend_unexpected_extra_named_error();
 			break;
-		default:
-			ZEND_ASSERT(error_code != ZPP_ERROR_OK);
+		case ZPP_ERROR_FAILURE:
+			ZEND_ASSERT(EG(exception) && "Should have produced an error already");
+			break;
+		EMPTY_SWITCH_DEFAULT_CASE()
 	}
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -242,8 +242,10 @@ ZEND_API ZEND_COLD void ZEND_FASTCALL zend_wrong_parameter_error(int error_code,`
`242`	`242`	`case ZPP_ERROR_UNEXPECTED_EXTRA_NAMED:`
`243`	`243`	`zend_unexpected_extra_named_error();`
`244`	`244`	`break;`
`245`		`- default:`
`246`		`- ZEND_ASSERT(error_code != ZPP_ERROR_OK);`
	`245`	`+ case ZPP_ERROR_FAILURE:`
	`246`	`+ ZEND_ASSERT(EG(exception) && "Should have produced an error already");`
	`247`	`+ break;`
	`248`	`+ EMPTY_SWITCH_DEFAULT_CASE()`
`247`	`249`	`}`
`248`	`250`	`}`
`249`	`251`	`/* }}} */`