Skip to content

Commit b9f8113

Browse files
authored
Autotools: Quote PHP_SUBST arguments in configure.ac (#14757)
1 parent 7711bdc commit b9f8113

File tree

1 file changed

+45
-47
lines changed

1 file changed

+45
-47
lines changed

configure.ac

Lines changed: 45 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,10 @@ PHP_VERSION="$PHP_MAJOR_VERSION.$PHP_MINOR_VERSION.$PHP_RELEASE_VERSION$PHP_EXTR
7272
PHP_VERSION_ID=`expr [$]PHP_MAJOR_VERSION \* 10000 + [$]PHP_MINOR_VERSION \* 100 + [$]PHP_RELEASE_VERSION`
7373

7474
dnl Allow version values to be used in Makefile.
75-
PHP_SUBST(PHP_MAJOR_VERSION)
76-
PHP_SUBST(PHP_MINOR_VERSION)
77-
PHP_SUBST(PHP_RELEASE_VERSION)
78-
PHP_SUBST(PHP_EXTRA_VERSION)
75+
PHP_SUBST([PHP_MAJOR_VERSION])
76+
PHP_SUBST([PHP_MINOR_VERSION])
77+
PHP_SUBST([PHP_RELEASE_VERSION])
78+
PHP_SUBST([PHP_EXTRA_VERSION])
7979

8080
dnl Define where extension directories are located in the configure context.
8181
AC_DEFUN([PHP_EXT_BUILDDIR],[$config_m4_dir])dnl
@@ -1482,40 +1482,38 @@ if test -n "${PHP_BUILD_ARCH}"; then
14821482
AC_DEFINE_UNQUOTED(PHP_BUILD_ARCH,"$PHP_BUILD_ARCH",[build architecture])
14831483
fi
14841484

1485-
PHP_SUBST(PHP_FASTCGI_OBJS)
1486-
PHP_SUBST(PHP_SAPI_OBJS)
1487-
PHP_SUBST(PHP_BINARY_OBJS)
1488-
PHP_SUBST(PHP_GLOBAL_OBJS)
1489-
1490-
PHP_SUBST(PHP_BINARIES)
1491-
PHP_SUBST(PHP_MODULES)
1492-
PHP_SUBST(PHP_ZEND_EX)
1493-
PHP_SUBST(bindir)
1494-
PHP_SUBST(sbindir)
1495-
PHP_SUBST(exec_prefix)
1485+
PHP_SUBST([PHP_FASTCGI_OBJS])
1486+
PHP_SUBST([PHP_SAPI_OBJS])
1487+
PHP_SUBST([PHP_BINARY_OBJS])
1488+
PHP_SUBST([PHP_GLOBAL_OBJS])
1489+
PHP_SUBST([PHP_BINARIES])
1490+
PHP_SUBST([PHP_MODULES])
1491+
PHP_SUBST([PHP_ZEND_EX])
1492+
PHP_SUBST([bindir])
1493+
PHP_SUBST([sbindir])
1494+
PHP_SUBST([exec_prefix])
14961495
PHP_SUBST_OLD([program_prefix])
14971496
PHP_SUBST_OLD([program_suffix])
1498-
PHP_SUBST(includedir)
1497+
PHP_SUBST([includedir])
14991498
PHP_SUBST_OLD([orig_libdir])
1500-
PHP_SUBST(libdir)
1501-
PHP_SUBST(mandir)
1502-
PHP_SUBST(phptempdir)
1503-
PHP_SUBST(prefix)
1504-
PHP_SUBST(localstatedir)
1505-
PHP_SUBST(datadir)
1506-
PHP_SUBST(datarootdir)
1507-
PHP_SUBST(sysconfdir)
1508-
1509-
PHP_SUBST(EXEEXT)
1510-
PHP_SUBST(CC)
1511-
PHP_SUBST(BUILD_CC)
1512-
PHP_SUBST(CFLAGS)
1513-
PHP_SUBST(CFLAGS_CLEAN)
1514-
PHP_SUBST(CPP)
1515-
PHP_SUBST(CPPFLAGS)
1516-
PHP_SUBST(CXX)
1517-
PHP_SUBST(CXXFLAGS)
1518-
PHP_SUBST(CXXFLAGS_CLEAN)
1499+
PHP_SUBST([libdir])
1500+
PHP_SUBST([mandir])
1501+
PHP_SUBST([phptempdir])
1502+
PHP_SUBST([prefix])
1503+
PHP_SUBST([localstatedir])
1504+
PHP_SUBST([datadir])
1505+
PHP_SUBST([datarootdir])
1506+
PHP_SUBST([sysconfdir])
1507+
PHP_SUBST([EXEEXT])
1508+
PHP_SUBST([CC])
1509+
PHP_SUBST([BUILD_CC])
1510+
PHP_SUBST([CFLAGS])
1511+
PHP_SUBST([CFLAGS_CLEAN])
1512+
PHP_SUBST([CPP])
1513+
PHP_SUBST([CPPFLAGS])
1514+
PHP_SUBST([CXX])
1515+
PHP_SUBST([CXXFLAGS])
1516+
PHP_SUBST([CXXFLAGS_CLEAN])
15191517
PHP_SUBST_OLD([EXTENSION_DIR])
15201518
PHP_SUBST([EXTRA_LDFLAGS])
15211519
PHP_SUBST([EXTRA_LDFLAGS_PROGRAM])
@@ -1524,16 +1522,16 @@ PHP_SUBST([ZEND_EXTRA_LIBS])
15241522
PHP_SUBST([INCLUDES])
15251523
PHP_SUBST([EXTRA_INCLUDES])
15261524
PHP_SUBST([INSTALL_IT])
1527-
PHP_SUBST(LIBTOOL)
1528-
PHP_SUBST(LN_S)
1525+
PHP_SUBST([LIBTOOL])
1526+
PHP_SUBST([LN_S])
15291527
PHP_SUBST([NATIVE_RPATHS])
1530-
PHP_SUBST(OVERALL_TARGET)
1531-
PHP_SUBST(PHP_RPATHS)
1532-
PHP_SUBST(PHP_SAPI)
1533-
PHP_SUBST(SHELL)
1534-
PHP_SUBST(PHP_FRAMEWORKS)
1535-
PHP_SUBST(PHP_FRAMEWORKPATH)
1536-
PHP_SUBST(INSTALL_HEADERS)
1528+
PHP_SUBST([OVERALL_TARGET])
1529+
PHP_SUBST([PHP_RPATHS])
1530+
PHP_SUBST([PHP_SAPI])
1531+
PHP_SUBST([SHELL])
1532+
PHP_SUBST([PHP_FRAMEWORKS])
1533+
PHP_SUBST([PHP_FRAMEWORKPATH])
1534+
PHP_SUBST([INSTALL_HEADERS])
15371535

15381536
old_CC=$CC
15391537

@@ -1653,9 +1651,9 @@ fi;
16531651
all_targets="\$(OVERALL_TARGET) \$(PHP_MODULES) \$(PHP_ZEND_EX) \$(PHP_BINARIES) $pharcmd"
16541652
install_targets="$install_sapi $install_modules $install_binaries install-build install-headers install-programs $install_pear $pharcmd_install"
16551653

1656-
PHP_SUBST(all_targets)
1657-
PHP_SUBST(install_targets)
1658-
PHP_SUBST(install_binary_targets)
1654+
PHP_SUBST([all_targets])
1655+
PHP_SUBST([install_targets])
1656+
PHP_SUBST([install_binary_targets])
16591657

16601658
PHP_INSTALL_HEADERS([Zend/ TSRM/ main/ main/streams/])
16611659
PHP_INSTALL_HEADERS([Zend/Optimizer], [ \

0 commit comments

Comments
 (0)