Skip to content

Commit d42d645

Browse files
datibbawdatibbaw
committed
Fixed bug #68128
Three issues are addressed: - RecursiveRegexIterator::accept() should accept non-empty arrays without applying any regular expression and RegexIterator::accept() should not accept an array. - RegexIterator::accept() should not accept an atom that fails to match anything, even when PREG_PATTERN_ORDER is used (which would return an array of empty arrays). - RecursiveRegexIterator::getChildren() should pass all constructor arguments to its child iterator instead of just the regular expression.
1 parent 320b9ef commit d42d645

8 files changed

+163
-285
lines changed

‎ext/spl/spl_engine.h

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,39 @@ static inline int spl_instantiate_arg_ex2(zend_class_entry *pce, zval *retval, z
5151
}
5252
/* }}} */
5353

54+
/* {{{ spl_instantiate_arg_n */
55+
static inline void spl_instantiate_arg_n(zend_class_entry *pce, zval *retval, int argc, zval *argv TSRMLS_DC)
56+
{
57+
zend_fcall_info fci;
58+
zend_fcall_info_cache fcc;
59+
zval dummy;
60+
61+
spl_instantiate(pce, retval TSRMLS_CC);
62+
63+
fci.size = sizeof(zend_fcall_info);
64+
fci.function_table = &pce->function_table;
65+
ZVAL_UNDEF(&fci.function_name);
66+
fci.object = Z_OBJ_P(retval);
67+
fci.symbol_table = NULL;
68+
fci.retval = &dummy;
69+
fci.param_count = 0;
70+
fci.params = NULL;
71+
fci.no_separation = 1;
72+
73+
zend_fcall_info_argp(&fci TSRMLS_CC, argc, argv);
74+
75+
fcc.initialized = 1;
76+
fcc.function_handler = pce->constructor;
77+
fcc.calling_scope = EG(scope);
78+
fcc.called_scope = pce;
79+
fcc.object = Z_OBJ_P(retval);
80+
81+
zend_call_function(&fci, &fcc TSRMLS_CC);
82+
83+
zend_fcall_info_args_clear(&fci, 1);
84+
}
85+
/* }}} */
86+
5487
#endif /* SPL_ENGINE_H */
5588

5689
/*

‎ext/spl/spl_iterators.c

Lines changed: 35 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2037,8 +2037,10 @@ SPL_METHOD(RegexIterator, accept)
20372037

20382038
if (Z_TYPE(intern->current.data) == IS_UNDEF) {
20392039
RETURN_FALSE;
2040+
} else if (Z_TYPE(intern->current.data) == IS_ARRAY) {
2041+
RETURN_FALSE;
20402042
}
2041-
2043+
20422044
if (intern->u.regex.flags & REGIT_USE_KEY) {
20432045
subject_ptr = &intern->current.key;
20442046
} else {
@@ -2074,8 +2076,7 @@ SPL_METHOD(RegexIterator, accept)
20742076
ZVAL_UNDEF(&intern->current.data);
20752077
php_pcre_match_impl(intern->u.regex.pce, subject, subject_len, &zcount,
20762078
&intern->current.data, intern->u.regex.mode == REGIT_MODE_ALL_MATCHES, intern->u.regex.use_flags, intern->u.regex.preg_flags, 0 TSRMLS_CC);
2077-
count = zend_hash_num_elements(Z_ARRVAL(intern->current.data));
2078-
RETVAL_BOOL(count > 0);
2079+
RETVAL_BOOL(Z_LVAL(zcount) > 0);
20792080
break;
20802081

20812082
case REGIT_MODE_SPLIT:
@@ -2254,7 +2255,7 @@ SPL_METHOD(RecursiveRegexIterator, __construct)
22542255
SPL_METHOD(RecursiveRegexIterator, getChildren)
22552256
{
22562257
spl_dual_it_object *intern;
2257-
zval retval, regex;
2258+
zval retval;
22582259

22592260
if (zend_parse_parameters_none() == FAILURE) {
22602261
return;
@@ -2264,13 +2265,39 @@ SPL_METHOD(RecursiveRegexIterator, getChildren)
22642265

22652266
zend_call_method_with_0_params(&intern->inner.zobject, intern->inner.ce, NULL, "getchildren", &retval);
22662267
if (!EG(exception)) {
2267-
ZVAL_STR_COPY(&regex, intern->u.regex.regex);
2268-
spl_instantiate_arg_ex2(Z_OBJCE_P(getThis()), return_value, &retval, &regex TSRMLS_CC);
2269-
zval_ptr_dtor(&regex);
2268+
zval args[5];
2269+
2270+
ZVAL_COPY(&args[0], &retval);
2271+
ZVAL_STR_COPY(&args[1], intern->u.regex.regex);
2272+
ZVAL_LONG(&args[2], intern->u.regex.mode);
2273+
ZVAL_LONG(&args[3], intern->u.regex.flags);
2274+
ZVAL_LONG(&args[4], intern->u.regex.preg_flags);
2275+
2276+
/* note: zval_ptr_dtor() is applied to all args */
2277+
spl_instantiate_arg_n(Z_OBJCE_P(getThis()), return_value, 5, args TSRMLS_CC);
22702278
}
22712279
zval_ptr_dtor(&retval);
22722280
} /* }}} */
22732281

2282+
SPL_METHOD(RecursiveRegexIterator, accept)
2283+
{
2284+
spl_dual_it_object *intern;
2285+
2286+
if (zend_parse_parameters_none() == FAILURE) {
2287+
return;
2288+
}
2289+
2290+
SPL_FETCH_AND_CHECK_DUAL_IT(intern, getThis());
2291+
2292+
if (Z_TYPE(intern->current.data) == IS_UNDEF) {
2293+
RETURN_FALSE;
2294+
} else if (Z_TYPE(intern->current.data) == IS_ARRAY) {
2295+
RETURN_BOOL(zend_hash_num_elements(Z_ARRVAL(intern->current.data)) > 0);
2296+
}
2297+
2298+
zend_call_method_with_0_params(getThis(), spl_ce_RegexIterator, NULL, "accept", return_value);
2299+
}
2300+
22742301
#endif
22752302

22762303
/* {{{ spl_dual_it_dtor */
@@ -2456,6 +2483,7 @@ ZEND_END_ARG_INFO();
24562483

24572484
static const zend_function_entry spl_funcs_RecursiveRegexIterator[] = {
24582485
SPL_ME(RecursiveRegexIterator, __construct, arginfo_rec_regex_it___construct, ZEND_ACC_PUBLIC)
2486+
SPL_ME(RecursiveRegexIterator, accept, arginfo_recursive_it_void, ZEND_ACC_PUBLIC)
24592487
SPL_ME(RecursiveFilterIterator, hasChildren, arginfo_recursive_it_void, ZEND_ACC_PUBLIC)
24602488
SPL_ME(RecursiveRegexIterator, getChildren, arginfo_recursive_it_void, ZEND_ACC_PUBLIC)
24612489
PHP_FE_END

‎ext/spl/tests/bug68128.phpt

Lines changed: 91 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,91 @@
1+
--TEST--
2+
Bug #68128 - RecursiveRegexIterator raises "Array to string conversion" notice
3+
--FILE--
4+
<?php
5+
6+
$array = new ArrayIterator(array('a', array('b', 'c')));
7+
$regex = new RegexIterator($array, '/Array/');
8+
9+
foreach ($regex as $match) {
10+
var_dump($match);
11+
}
12+
13+
$rArrayIterator = new RecursiveArrayIterator(array('test1', array('tet3', 'test4', 'test5')));
14+
$rRegexIterator = new RecursiveRegexIterator($rArrayIterator, '/^(t)est(\d*)/',
15+
RecursiveRegexIterator::ALL_MATCHES, 0, PREG_PATTERN_ORDER);
16+
17+
foreach ($rRegexIterator as $key1 => $value1) {
18+
19+
if ($rRegexIterator->hasChildren()) {
20+
21+
// print all children
22+
echo "Children: ";
23+
foreach ($rRegexIterator->getChildren() as $key => $value) {
24+
print_r($value);
25+
}
26+
echo "\n";
27+
} else {
28+
echo "No children ";
29+
print_r($value1);
30+
echo "\n";
31+
}
32+
}
33+
34+
?>
35+
--EXPECT--
36+
No children Array
37+
(
38+
[0] => Array
39+
(
40+
[0] => test1
41+
)
42+
43+
[1] => Array
44+
(
45+
[0] => t
46+
)
47+
48+
[2] => Array
49+
(
50+
[0] => 1
51+
)
52+
53+
)
54+
55+
Children: Array
56+
(
57+
[0] => Array
58+
(
59+
[0] => test4
60+
)
61+
62+
[1] => Array
63+
(
64+
[0] => t
65+
)
66+
67+
[2] => Array
68+
(
69+
[0] => 4
70+
)
71+
72+
)
73+
Array
74+
(
75+
[0] => Array
76+
(
77+
[0] => test5
78+
)
79+
80+
[1] => Array
81+
(
82+
[0] => t
83+
)
84+
85+
[2] => Array
86+
(
87+
[0] => 5
88+
)
89+
90+
)
91+

‎ext/spl/tests/iterator_048.phpt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@ class MyRecursiveRegexIterator extends RecursiveRegexIterator
1313
var_dump($v);
1414
}
1515
}
16-
17-
function accept()
18-
{
19-
return $this->hasChildren() || parent::accept();
20-
}
2116
}
2217

2318
$ar = new RecursiveArrayIterator(array('Foo', array('Bar'), 'FooBar', array('Baz'), 'Biz'));

‎ext/spl/tests/iterator_050.phpt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ array(3) {
4646
[2]=>
4747
%s(1) "2"
4848
}
49-
50-
Notice: Array to string conversion in %siterator_050.php on line %d
5149
int(0)
5250
array(2) {
5351
[0]=>
@@ -69,8 +67,6 @@ array(2) {
6967
[1]=>
7068
%s(1) "1"
7169
}
72-
73-
Notice: Array to string conversion in %siterator_050.php on line %d
7470
object(ArrayIterator)#%d (1) {
7571
%s"storage"%s"ArrayIterator":private]=>
7672
array(9) {

0 commit comments

Comments
 (0)