Skip to content

Commit d5af2de

Browse files
TimWollanielsdos
andcommitted
Add deprecation message for libxml_disable_entity_loader
Co-authored-by: Niels Dossche <[email protected]>
1 parent d3a7a69 commit d5af2de

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

ext/libxml/libxml.stub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ function libxml_get_errors(): array {}
179179

180180
function libxml_clear_errors(): void {}
181181

182-
#[\Deprecated(since: '8.0')]
182+
#[\Deprecated(message: 'as external entity loading is disabled by default', since: '8.0')]
183183
function libxml_disable_entity_loader(bool $disable = true): bool {}
184184

185185
function libxml_set_external_entity_loader(?callable $resolver_function): bool {}

ext/libxml/libxml_arginfo.h

Lines changed: 9 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ext/libxml/tests/libxml_disable_entity_loader.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ echo "Done\n";
3737
--EXPECTF--
3838
bool(true)
3939

40-
Deprecated: Function libxml_disable_entity_loader() is deprecated since 8.0 in %s on line %d
40+
Deprecated: Function libxml_disable_entity_loader() is deprecated since 8.0, as external entity loading is disabled by default in %s on line %d
4141
bool(false)
4242

4343
Warning: DOMDocument::loadXML(): I/O warning : failed to load external entity "%s" in %s on line %d

ext/libxml/tests/libxml_disable_entity_loader_2.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ echo "Done\n";
3737
--EXPECTF--
3838
bool(true)
3939

40-
Deprecated: Function libxml_disable_entity_loader() is deprecated since 8.0 in %s on line %d
40+
Deprecated: Function libxml_disable_entity_loader() is deprecated since 8.0, as external entity loading is disabled by default in %s on line %d
4141
bool(false)
4242

4343
Warning: DOMDocument::loadXML(): %Sfailed to load external entity "%s" in %s on line %d

0 commit comments

Comments
 (0)