Remove unused add_property_TYPE() APIs

Array version usage: https://sourcegraph.com/search?q=context:global+lang:C+lang:C%2B%2B+add_property_array+-file:Zend/zend_API%5C.h&patternType=standard&sm=1&groupBy=repo

Results are unrelated.

Object version usage: https://sourcegraph.com/search?q=context:global+lang:C+lang:C%2B%2B+add_property_object+-file:Zend/zend_API%5C.h&patternType=standard&sm=1&groupBy=repo

Results are unrelated.

Reference version: https://sourcegraph.com/search?q=context:global+lang:C+lang:C%2B%2B+add_property_reference+-file:Zend/zend_API%5C.h&patternType=standard&sm=1&groupBy=repo

No results.

Author: Girgias

UPGRADING.INTERNALS

@@ -76,7 +76,8 @@ PHP 8.3 INTERNALS UPGRADE NOTES
   - add_property_array_ex()
   - add_property_object_ex()
   - add_property_reference_ex()
-  As there exists no equivalent.
+  Which have been removed, use zend_update_property() and wrap the value in
+  a zval* manually.
   It is recommended to convert these usages to the zend_update_property_TYPE()
   functions.
 

Zend/zend_API.c

@@ -2115,46 +2115,6 @@ ZEND_API zend_result array_set_zval_key(HashTable *ht, zval *key, zval *value) /
 }
 /* }}} */
 
-ZEND_API void add_property_resource_ex(zval *arg, const char *key, size_t key_len, zend_resource *r) /* {{{ */
-{
-	zval tmp;
-
-	ZVAL_RES(&tmp, r);
-	add_property_zval_ex(arg, key, key_len, &tmp);
-	zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */
-}
-/* }}} */
-
-ZEND_API void add_property_array_ex(zval *arg, const char *key, size_t key_len, zend_array *arr) /* {{{ */
-{
-	zval tmp;
-
-	ZVAL_ARR(&tmp, arr);
-	add_property_zval_ex(arg, key, key_len, &tmp);
-	zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */
-}
-/* }}} */
-
-ZEND_API void add_property_object_ex(zval *arg, const char *key, size_t key_len, zend_object *obj) /* {{{ */
-{
-	zval tmp;
-
-	ZVAL_OBJ(&tmp, obj);
-	add_property_zval_ex(arg, key, key_len, &tmp);
-	zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */
-}
-/* }}} */
-
-ZEND_API void add_property_reference_ex(zval *arg, const char *key, size_t key_len, zend_reference *ref) /* {{{ */
-{
-	zval tmp;
-
-	ZVAL_REF(&tmp, ref);
-	add_property_zval_ex(arg, key, key_len, &tmp);
-	zval_ptr_dtor(&tmp); /* write_property will add 1 to refcount */
-}
-/* }}} */
-
 ZEND_API zend_result zend_startup_module_ex(zend_module_entry *module) /* {{{ */
 {
 	size_t name_len;

Zend/zend_API.h

@@ -559,22 +559,13 @@ static zend_always_inline void add_property_stringl(zval *z_object, const char *
 static zend_always_inline void add_property_stringl_ex(zval *z_object, const char *name, size_t name_length, const char *value, size_t value_len) {
 	zend_update_property_stringl(Z_OBJCE_P(z_object), Z_OBJ_P(z_object), name, name_length, value, value_len);
 }
+/* Resource variant only has non ex version as it is rarely used */
+static zend_always_inline void add_property_resource(zval *z_object, const char *name, zend_resource *resource) {
+	zval tmp;
 
-ZEND_API void add_property_resource_ex(zval *arg, const char *key, size_t key_len, zend_resource *r);
-ZEND_API void add_property_array_ex(zval *arg, const char *key, size_t key_len, zend_array *arr);
-ZEND_API void add_property_object_ex(zval *arg, const char *key, size_t key_len, zend_object *obj);
-ZEND_API void add_property_reference_ex(zval *arg, const char *key, size_t key_len, zend_reference *ref);
-static zend_always_inline void add_property_resource(zval *arg, const char *key, zend_resource *r) {
-	add_property_resource_ex(arg, key, strlen(key), r);
-}
-static zend_always_inline void add_property_array(zval *arg, const char *key, zend_array *arr) {
-	add_property_array_ex(arg, key, strlen(key), arr);
-}
-static zend_always_inline void add_property_object(zval *arg, const char *key, zend_object *obj) {
-	add_property_object_ex(arg, key, strlen(key), obj);
-}
-static zend_always_inline void add_property_reference(zval *arg, const char *key, zend_reference *ref) {
-	add_property_reference_ex(arg, key, strlen(key), ref);
+    ZVAL_RES(&tmp, resource);
+	zend_update_property(Z_OBJCE_P(z_object), Z_OBJ_P(z_object), name, strlen(name), &tmp);
+	zval_ptr_dtor(&tmp); /* Updating property will increase refcount by 1 */
 }
 
 ZEND_API zend_result zend_update_static_property_ex(zend_class_entry *scope, zend_string *name, zval *value);