Skip to content

Commit dba5bbb

Browse files
committed
Remove dead code
1 parent 79c71c9 commit dba5bbb

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

ext/mysqlnd/mysqlnd_wireprotocol.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2563,7 +2563,7 @@ static enum_func_status
25632563
MYSQLND_METHOD(mysqlnd_protocol, send_command_handle_response)(
25642564
MYSQLND_PROTOCOL_PAYLOAD_DECODER_FACTORY * payload_decoder_factory,
25652565
const enum mysqlnd_packet_type ok_packet,
2566-
const bool silent,
2566+
const bool silent, /* This is a dead parameter */
25672567
const enum php_mysqlnd_server_command command,
25682568
const bool ignore_upsert_status, /* actually used only by LOAD DATA. COM_QUERY and COM_EXECUTE handle the responses themselves */
25692569

@@ -2586,12 +2586,8 @@ MYSQLND_METHOD(mysqlnd_protocol, send_command_handle_response)(
25862586
break;
25872587
default:
25882588
SET_CLIENT_ERROR(error_info, CR_MALFORMED_PACKET, UNKNOWN_SQLSTATE, "Malformed packet");
2589-
php_error_docref(NULL, E_ERROR, "Wrong response packet %u passed to the function", ok_packet);
25902589
break;
25912590
}
2592-
if (!silent && error_info->error_no == CR_MALFORMED_PACKET) {
2593-
php_error_docref(NULL, E_WARNING, "Error while reading %s's response packet. PID=%d", mysqlnd_command_to_text[command], getpid());
2594-
}
25952591
DBG_INF(ret == PASS ? "PASS":"FAIL");
25962592
DBG_RETURN(ret);
25972593
}

0 commit comments

Comments
 (0)