Convert warning to assetion in MySQL PDO driver

Girgias · Girgias · commit ddff69e2f398 · 2020-09-12T23:53:52.000+02:00
diff --git a/ext/pdo_mysql/pdo_mysql.c b/ext/pdo_mysql/pdo_mysql.c
@@ -68,10 +68,7 @@ static MYSQLND * pdo_mysql_convert_zv_to_mysqlnd(zval * zv)
 			return NULL;
 		}
 
-		if (dbh->driver != &pdo_mysql_driver) {
-			php_error_docref(NULL, E_WARNING, "Provided PDO instance is not using MySQL but %s", dbh->driver->driver_name);
-			return NULL;
-		}
+		ZEND_ASSERT(dbh->driver == &pdo_mysql_driver);
 
 		return ((pdo_mysql_db_handle *)dbh->driver_data)->server;
 	}

Original file line number	Diff line number	Diff line change
`@@ -68,10 +68,7 @@ static MYSQLND * pdo_mysql_convert_zv_to_mysqlnd(zval * zv)`
`68`	`68`	`return NULL;`
`69`	`69`	`}`
`70`	`70`
`71`		`- if (dbh->driver != &pdo_mysql_driver) {`
`72`		`- php_error_docref(NULL, E_WARNING, "Provided PDO instance is not using MySQL but %s", dbh->driver->driver_name);`
`73`		`- return NULL;`
`74`		`- }`
	`71`	`+ ZEND_ASSERT(dbh->driver == &pdo_mysql_driver);`
`75`	`72`
`76`	`73`	`return ((pdo_mysql_db_handle *)dbh->driver_data)->server;`
`77`	`74`	`}`