Skip to content

Commit df60c50

Browse files
author
Stanley Sufficool
committed
pdo_dblib - improve test skip messages
1 parent f6f0f65 commit df60c50

File tree

5 files changed

+15
-42
lines changed

5 files changed

+15
-42
lines changed

ext/pdo_dblib/tests/bug_38955.phpt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,10 @@
44
<?php
55
if (!extension_loaded('pdo_dblib')) die('skip not loaded');
66
require dirname(__FILE__) . '/config.inc';
7-
try {
8-
$db = new PDO( getenv('PDOTEST_DSN'), getenv('PDOTEST_USER'), getenv('PDOTEST_PASS'));
9-
} catch (PDOException $e) {
10-
die('skip ' . $e->getMessage());
11-
}
127
?>
138
--FILE--
149
<?php
1510
require dirname(__FILE__) . '/config.inc';
16-
$db = new PDO( getenv('PDOTEST_DSN'), getenv('PDOTEST_USER'), getenv('PDOTEST_PASS'));
17-
$db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
18-
$db->setAttribute(PDO::ATTR_STRINGIFY_FETCHES, false);
1911

2012
/*We see these rows */
2113
$db->query("CREATE table php_test(val int)");

ext/pdo_dblib/tests/bug_45876.phpt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,10 @@ PDO_DBLIB: Does not support get column meta
44
<?php
55
if (!extension_loaded('pdo_dblib')) die('skip not loaded');
66
require dirname(__FILE__) . '/config.inc';
7-
try {
8-
$db = new PDO( getenv('PDOTEST_DSN'), getenv('PDOTEST_USER'), getenv('PDOTEST_PASS'));
9-
} catch (PDOException $e) {
10-
die('skip ' . $e->getMessage());
11-
}
127
?>
138
--FILE--
149
<?php
1510
require dirname(__FILE__) . '/config.inc';
16-
$db = new PDO( getenv('PDOTEST_DSN'), getenv('PDOTEST_USER'), getenv('PDOTEST_PASS'));
17-
$db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
18-
$db->setAttribute(PDO::ATTR_STRINGIFY_FETCHES, false);
1911

2012
$stmt = $db->prepare("select ic1.* from information_schema.columns ic1");
2113
$stmt->execute();

ext/pdo_dblib/tests/bug_47588.phpt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,10 @@ PDO_DBLIB: Quoted field names
44
<?php
55
if (!extension_loaded('pdo_dblib')) die('skip not loaded');
66
require dirname(__FILE__) . '/config.inc';
7-
try {
8-
$db = new PDO( getenv('PDOTEST_DSN'), getenv('PDOTEST_USER'), getenv('PDOTEST_PASS'));
9-
} catch (PDOException $e) {
10-
die('skip ' . $e->getMessage());
11-
}
12-
137
?>
148
--FILE--
159
<?php
1610
require dirname(__FILE__) . '/config.inc';
17-
$db = new PDO( getenv('PDOTEST_DSN'), getenv('PDOTEST_USER'), getenv('PDOTEST_PASS'));
18-
$db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
19-
$db->setAttribute(PDO::ATTR_STRINGIFY_FETCHES, false);
2011

2112
$db->query('CREATE TABLE "Test Table" ("My Field" int, "Another Field" varchar(32) not null default \'test_string\')');
2213
$db->query('INSERT INTO "Test Table" ("My Field") values(1)');

ext/pdo_dblib/tests/bug_50755.phpt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,10 @@ PDO_DBLIB: Out of memory on large recordsets
44
<?php
55
if (!extension_loaded('pdo_dblib')) die('skip not loaded');
66
require dirname(__FILE__) . '/config.inc';
7-
try {
8-
$db = new PDO( getenv('PDOTEST_DSN'), getenv('PDOTEST_USER'), getenv('PDOTEST_PASS'));
9-
} catch (PDOException $e) {
10-
die('skip ' . $e->getMessage());
11-
}
127
?>
138
--FILE--
149
<?php
1510
require dirname(__FILE__) . '/config.inc';
16-
$db = new PDO( getenv('PDOTEST_DSN'), getenv('PDOTEST_USER'), getenv('PDOTEST_PASS'));
17-
$db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
18-
$db->setAttribute(PDO::ATTR_STRINGIFY_FETCHES, false);
1911

2012
/* This should be sufficient to overflow any buffers */
2113
$stmt = $db->prepare("select *

ext/pdo_dblib/tests/config.inc

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,26 @@
11
<?php
22

33
if (false !== getenv('PDO_DBLIB_TEST_DSN'))
4-
$config['ENV']['PDOTEST_DSN'] = getenv('PDO_DBLIB_TEST_DSN');
4+
$dsn = getenv('PDO_DBLIB_TEST_DSN');
55
else
6-
$config['ENV']['PDOTEST_DSN'] = 'dblib:host=localhost dbname=test';
6+
$dsn = 'dblib:host=localhost;dbname=test';
77

88
if (false !== getenv('PDO_DBLIB_TEST_USER'))
9-
$config['ENV']['PDOTEST_USER'] = getenv('PDO_DBLIB_TEST_USER');
9+
$user = getenv('PDO_DBLIB_TEST_USER');
10+
else
11+
$user = 'php';
12+
1013

1114
if (false !== getenv('PDO_DBLIB_TEST_PASS'))
12-
$config['ENV']['PDOTEST_PASS'] = getenv('PDO_DBLIB_TEST_PASS');
15+
$pass = getenv('PDO_DBLIB_TEST_PASS');
16+
else
17+
$pass = 'password';
1318

14-
if (false !== getenv('PDO_DBLIB_TEST_ATTR'))
15-
$config['ENV']['PDOTEST_ATTR'] = getenv('PDO_DBLIB_TEST_ATTR');
16-
17-
foreach ($config['ENV'] as $k => $v) {
18-
putenv("$k=$v");
19+
try {
20+
$db = new PDO($dsn, $user, $pass);
21+
$db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
22+
$db->setAttribute(PDO::ATTR_STRINGIFY_FETCHES, false);
23+
} catch (PDOException $e) {
24+
die('skip ' . $e->getMessage());
1925
}
2026
?>

0 commit comments

Comments
 (0)