Update ext/intl/formatter/formatter_format.c

lucaswerkmeister · Girgias · web-flow · commit e12cf31b4fe6 · 2023-11-27T20:34:32.000+01:00
Co-authored-by: Gina Peter Banyard &lt;girgias@php.net&gt;
diff --git a/ext/intl/formatter/formatter_format.c b/ext/intl/formatter/formatter_format.c
@@ -99,7 +99,7 @@ PHP_FUNCTION( numfmt_format )
 			bool failed = true;
 			int64_t value = zval_try_get_long(number, &failed);
 			if (failed) {
-				zend_argument_value_error(object ? 1 : 2, "must be numeric");
+				zend_argument_type_error(object ? 1 : 2, "must be of type int when argument #2 ($format) is NumberFormatter::TYPE_INT64");
 				RETURN_THROWS();
 			}
 			formatted_len = unum_formatInt64(FORMATTER_OBJECT(nfo), value, formatted, formatted_len, NULL, &INTL_DATA_ERROR_CODE(nfo));

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ PHP_FUNCTION( numfmt_format )`
`99`	`99`	`bool failed = true;`
`100`	`100`	`int64_t value = zval_try_get_long(number, &failed);`
`101`	`101`	`if (failed) {`
`102`		`- zend_argument_value_error(object ? 1 : 2, "must be numeric");`
	`102`	`+ zend_argument_type_error(object ? 1 : 2, "must be of type int when argument #2 ($format) is NumberFormatter::TYPE_INT64");`
`103`	`103`	`RETURN_THROWS();`
`104`	`104`	`}`
`105`	`105`	`formatted_len = unum_formatInt64(FORMATTER_OBJECT(nfo), value, formatted, formatted_len, NULL, &INTL_DATA_ERROR_CODE(nfo));`