Skip to content

Commit e3cde84

Browse files
committed
ext/readline: fix global readline vars when updating rl_line_buffer.
if the new value was larger, rl_line_buffer_length was never updated. neither was rl_end.
1 parent a7f0fe1 commit e3cde84

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

ext/readline/readline.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,11 +183,16 @@ PHP_FUNCTION(readline_info)
183183
if (zend_string_equals_literal_ci(what,"line_buffer")) {
184184
oldstr = rl_line_buffer;
185185
if (value) {
186-
/* XXX if (rl_line_buffer) free(rl_line_buffer); */
187186
if (!try_convert_to_string(value)) {
188187
RETURN_THROWS();
189188
}
190-
rl_line_buffer = strdup(Z_STRVAL_P(value));
189+
if (strlen(oldstr) < Z_STRLEN_P(value)) {
190+
rl_extend_line_buffer(Z_STRLEN_P(value) + 1);
191+
}
192+
strcpy(rl_line_buffer, Z_STRVAL_P(value));
193+
#ifndef PHP_WIN32
194+
rl_end = Z_STRLEN_P(value);
195+
#endif
191196
}
192197
RETVAL_STRING(SAFE_STRING(oldstr));
193198
} else if (zend_string_equals_literal_ci(what, "point")) {

0 commit comments

Comments
 (0)