Skip to content

Commit e928402

Browse files
BilgeBilge
committed
Fixed default invalid context tracking.
Added more test cases for default expressions.
1 parent 6acbffb commit e928402

File tree

7 files changed

+99
-13
lines changed

7 files changed

+99
-13
lines changed

‎Zend/tests/default_expression/default_expressions.phpt

Lines changed: 82 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@ Tests an exhaustive list of valid expressions containing the default keyword
33
--FILE--
44
<?php
55

6+
class C {}
67
function F($V = 2) { return $V; }
8+
function FA($V = ['Alfa', 'Bravo']) { return $V; }
9+
function FE($V = new Exception) { return $V; }
10+
function FO($V = new C) { return $V; }
711

812
echo "Numeric binary operators (LHS)\n";
913
var_dump(F(default + 1));
@@ -63,6 +67,25 @@ var_dump(F(0 ?: default));
6367
var_dump(F(default ?? 0));
6468
var_dump(F(null ?? default));
6569

70+
echo "\nVariable assignment\n";
71+
F($V = default); var_dump($V);
72+
F($V += default); var_dump($V);
73+
F($V -= default); var_dump($V);
74+
F($V *= default); var_dump($V);
75+
F($V **= default); var_dump($V);
76+
F($V /= default); var_dump($V);
77+
F($V <<= default); var_dump($V);
78+
F($V >>= default); var_dump($V);
79+
F($V %= default); var_dump($V);
80+
F($V &= default); var_dump($V);
81+
F($V |= default); var_dump($V);
82+
F($V ^= default); var_dump($V);
83+
F($V .= default); var_dump($V);
84+
F($U ??= default); var_dump($U);
85+
FA(list($V) = default); var_dump($V);
86+
FA([, $V] = default); var_dump($V);
87+
// TODO: Variable expressions?
88+
6689
echo "\nCasts\n";
6790
var_dump(F((int)default));
6891
var_dump(F((double)default));
@@ -71,22 +94,45 @@ var_dump(F((array)default));
7194
var_dump(F((object)default));
7295
var_dump(F((bool)default));
7396

97+
echo "\nParens\n";
98+
var_dump(F((((default)))));
99+
100+
//echo "\nGenerators\n";
101+
//var_dump(F(fn () => yield default)()->current());
102+
74103
echo "\nInternal functions\n";
75104
var_dump(F(empty(default)));
76105
// eval() makes no sense.
77106
// exit() makes no sense.
78107
// TODO?
79-
// include()
80-
// include_once()
81-
// require()
82-
// require_once()
108+
// include
109+
// include_once
110+
// require
111+
// require_once
83112

84113
echo "\nMatch tier\n";
85114
var_dump(F(match(default) { default => default }));
86115
var_dump(F(match(default) { 2 => 3 }));
87116

117+
echo "\nInstanceof tier\n";
118+
var_dump(FO(default instanceof C));
119+
var_dump(FO(default instanceof D));
120+
121+
echo "\nClone tier\n";
122+
var_dump(FO(clone default));
123+
124+
echo "\nThrow tier\n";
125+
try {
126+
FE(throw default);
127+
} catch (Exception $E) {
128+
var_dump($E::class);
129+
}
130+
88131
echo "\nPrint tier\n";
89132
var_dump(F(print default));
133+
134+
// TODO: Silence operator?
135+
90136
?>
91137
--EXPECT--
92138
Numeric binary operators (LHS)
@@ -147,6 +193,24 @@ int(2)
147193
int(2)
148194
int(2)
149195

196+
Variable assignment
197+
int(2)
198+
int(4)
199+
int(2)
200+
int(4)
201+
int(16)
202+
int(8)
203+
int(32)
204+
int(8)
205+
int(0)
206+
int(0)
207+
int(2)
208+
int(0)
209+
string(2) "02"
210+
int(2)
211+
string(4) "Alfa"
212+
string(5) "Bravo"
213+
150214
Casts
151215
int(2)
152216
float(2)
@@ -161,12 +225,26 @@ object(stdClass)#1 (1) {
161225
}
162226
bool(true)
163227

228+
Parens
229+
int(2)
230+
164231
Internal functions
165232
bool(false)
166233

167234
Match tier
168235
int(2)
169236
int(3)
170237

238+
Instanceof tier
239+
bool(true)
240+
bool(false)
241+
242+
Clone tier
243+
object(C)#2 (0) {
244+
}
245+
246+
Throw tier
247+
string(9) "Exception"
248+
171249
Print tier
172250
2int(1)

‎Zend/tests/default_expression/invalid_context2.phpt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
--TEST--
2+
Tests specifying the default keyword in an invalid context throws a compile error (2)
3+
--FILE--
4+
<?php
5+
6+
function F($V = 2) { return $V; }
7+
F(fn () => default)();
8+
?>
9+
--EXPECTF--
10+
Fatal error: Cannot use default in non-argument context. in %s on line %d

‎Zend/zend_compile.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,7 @@ void zend_oparray_context_begin(zend_oparray_context *prev_context, zend_op_arra
340340
CG(context).in_jmp_frameless_branch = false;
341341
CG(context).active_property_info = NULL;
342342
CG(context).active_property_hook_kind = (zend_property_hook_kind)-1;
343+
CG(context).arg_num = 0;
343344
}
344345
/* }}} */
345346

@@ -3701,7 +3702,7 @@ static uint32_t zend_compile_args(
37013702
uint32_t i;
37023703
bool uses_arg_unpack = 0;
37033704
uint32_t arg_count = 0; /* number of arguments not including unpacks */
3704-
uint32_t prev_arg_num = CG(arg_num);
3705+
uint32_t prev_arg_num = CG(context).arg_num;
37053706

37063707
/* Whether named arguments are used syntactically, to enforce language level limitations.
37073708
* May not actually use named argument passing. */
@@ -3779,7 +3780,7 @@ static uint32_t zend_compile_args(
37793780
arg_count++;
37803781
}
37813782

3782-
CG(arg_num) = arg_num;
3783+
CG(context).arg_num = arg_num;
37833784

37843785
/* Treat passing of $GLOBALS the same as passing a call.
37853786
* This will error at runtime if the argument is by-ref. */
@@ -3895,15 +3896,15 @@ static uint32_t zend_compile_args(
38953896
zend_emit_op(NULL, ZEND_CHECK_UNDEF_ARGS, NULL, NULL);
38963897
}
38973898

3898-
CG(arg_num) = prev_arg_num;
3899+
CG(context).arg_num = prev_arg_num;
38993900

39003901
return arg_count;
39013902
}
39023903
/* }}} */
39033904

39043905
static void zend_compile_default(znode *result, zend_ast *ast)
39053906
{
3906-
uint32_t arg_num = CG(arg_num);
3907+
uint32_t arg_num = CG(context).arg_num;
39073908

39083909
if (arg_num == 0) {
39093910
zend_error_noreturn(E_COMPILE_ERROR, "Cannot use default in non-argument context.");

‎Zend/zend_compile.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,7 @@ typedef struct _zend_oparray_context {
207207
const zend_property_info *active_property_info;
208208
zend_property_hook_kind active_property_hook_kind;
209209
bool in_jmp_frameless_branch;
210+
uint32_t arg_num; // Current 1-based argument index if compiling arguments, otherwise zero.
210211
} zend_oparray_context;
211212

212213
/* Class, property and method flags class|meth.|prop.|const*/

‎Zend/zend_globals.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,9 +154,6 @@ struct _zend_compiler_globals {
154154
uint32_t rtd_key_counter;
155155

156156
zend_stack short_circuiting_opnums;
157-
158-
// Current 1-based argument index if compiling arguments, otherwise zero.
159-
uint32_t arg_num;
160157
#ifdef ZTS
161158
uint32_t copied_functions_count;
162159
#endif

‎Zend/zend_language_parser.y

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1313,6 +1313,7 @@ expr:
13131313
| '@' expr { $$ = zend_ast_create(ZEND_AST_SILENCE, $2); }
13141314
| scalar { $$ = $1; }
13151315
| '`' backticks_expr '`' { $$ = zend_ast_create(ZEND_AST_SHELL_EXEC, $2); }
1316+
| T_DEFAULT { $$ = zend_ast_create(ZEND_AST_DEFAULT); }
13161317
| T_PRINT expr { $$ = zend_ast_create(ZEND_AST_PRINT, $2); }
13171318
| T_YIELD { $$ = zend_ast_create(ZEND_AST_YIELD, NULL, NULL); CG(extra_fn_flags) |= ZEND_ACC_GENERATOR; }
13181319
| T_YIELD expr { $$ = zend_ast_create(ZEND_AST_YIELD, $2, NULL); CG(extra_fn_flags) |= ZEND_ACC_GENERATOR; }
@@ -1322,7 +1323,6 @@ expr:
13221323
| inline_function { $$ = $1; }
13231324
| attributes inline_function { $$ = zend_ast_with_attributes($2, $1); }
13241325
| T_STATIC inline_function { $$ = $2; ((zend_ast_decl *) $$)->flags |= ZEND_ACC_STATIC; }
1325-
| T_DEFAULT { $$ = zend_ast_create(ZEND_AST_DEFAULT); }
13261326
| attributes T_STATIC inline_function
13271327
{ $$ = zend_ast_with_attributes($3, $1); ((zend_ast_decl *) $$)->flags |= ZEND_ACC_STATIC; }
13281328
| match { $$ = $1; }

‎Zend/zend_language_scanner.l

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -595,7 +595,6 @@ static zend_op_array *zend_compile(int type)
595595
CG(in_compilation) = 1;
596596
CG(ast) = NULL;
597597
CG(ast_arena) = zend_arena_create(1024 * 32);
598-
CG(arg_num) = 0;
599598

600599
if (!zendparse()) {
601600
int last_lineno = CG(zend_lineno);

0 commit comments

Comments
 (0)