Skip to content

Commit e983de1

Browse files
Using the new error message always with null
1 parent b8fbef4 commit e983de1

File tree

3 files changed

+27
-26
lines changed

3 files changed

+27
-26
lines changed

ext/standard/string.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1030,7 +1030,7 @@ PHP_FUNCTION(implode)
10301030
ZEND_PARSE_PARAMETERS_START(1, 2)
10311031
Z_PARAM_ARRAY_HT_OR_STR(arg1_array, arg1_str)
10321032
Z_PARAM_OPTIONAL
1033-
Z_PARAM_ARRAY_HT(pieces)
1033+
Z_PARAM_ARRAY_HT_OR_NULL(pieces)
10341034
ZEND_PARSE_PARAMETERS_END();
10351035

10361036
if (arg1_str != NULL && pieces == NULL) {

ext/standard/tests/strings/implode_error.phpt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
--TEST--
2+
Test implode() function: error conditions
23
--FILE--
34
<?php
45
/* only glue */
@@ -23,5 +24,5 @@ try {
2324
}
2425
--EXPECTF--
2526
implode(): If argument #1 ($separator) is of type string, argument #2 ($array) must be of type array, null given
26-
implode(): Argument #2 ($array) must be of type array, null given
27-
implode(): Argument #2 ($array) must be of type array, string given
27+
implode(): If argument #1 ($separator) is of type string, argument #2 ($array) must be of type array, null given
28+
implode(): Argument #2 ($array) must be of type ?array, string given

ext/standard/tests/strings/join_error1.phpt

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -102,49 +102,49 @@ echo "Done\n";
102102

103103
--- Testing join() by supplying different values for 'pieces' argument ---
104104
-- Iteration 1 --
105-
join(): Argument #2 ($array) must be of type array, int given
105+
join(): Argument #2 ($array) must be of type ?array, int given
106106
-- Iteration 2 --
107-
join(): Argument #2 ($array) must be of type array, int given
107+
join(): Argument #2 ($array) must be of type ?array, int given
108108
-- Iteration 3 --
109-
join(): Argument #2 ($array) must be of type array, int given
109+
join(): Argument #2 ($array) must be of type ?array, int given
110110
-- Iteration 4 --
111-
join(): Argument #2 ($array) must be of type array, int given
111+
join(): Argument #2 ($array) must be of type ?array, int given
112112
-- Iteration 5 --
113-
join(): Argument #2 ($array) must be of type array, float given
113+
join(): Argument #2 ($array) must be of type ?array, float given
114114
-- Iteration 6 --
115-
join(): Argument #2 ($array) must be of type array, float given
115+
join(): Argument #2 ($array) must be of type ?array, float given
116116
-- Iteration 7 --
117-
join(): Argument #2 ($array) must be of type array, float given
117+
join(): Argument #2 ($array) must be of type ?array, float given
118118
-- Iteration 8 --
119-
join(): Argument #2 ($array) must be of type array, float given
119+
join(): Argument #2 ($array) must be of type ?array, float given
120120
-- Iteration 9 --
121-
join(): Argument #2 ($array) must be of type array, float given
121+
join(): Argument #2 ($array) must be of type ?array, float given
122122
-- Iteration 10 --
123-
join(): Argument #2 ($array) must be of type array, true given
123+
join(): Argument #2 ($array) must be of type ?array, true given
124124
-- Iteration 11 --
125-
join(): Argument #2 ($array) must be of type array, false given
125+
join(): Argument #2 ($array) must be of type ?array, false given
126126
-- Iteration 12 --
127-
join(): Argument #2 ($array) must be of type array, true given
127+
join(): Argument #2 ($array) must be of type ?array, true given
128128
-- Iteration 13 --
129-
join(): Argument #2 ($array) must be of type array, false given
129+
join(): Argument #2 ($array) must be of type ?array, false given
130130
-- Iteration 14 --
131-
join(): Argument #2 ($array) must be of type array, string given
131+
join(): Argument #2 ($array) must be of type ?array, string given
132132
-- Iteration 15 --
133-
join(): Argument #2 ($array) must be of type array, string given
133+
join(): Argument #2 ($array) must be of type ?array, string given
134134
-- Iteration 16 --
135-
join(): Argument #2 ($array) must be of type array, test given
135+
join(): Argument #2 ($array) must be of type ?array, test given
136136
-- Iteration 17 --
137-
join(): Argument #2 ($array) must be of type array, string given
137+
join(): Argument #2 ($array) must be of type ?array, string given
138138
-- Iteration 18 --
139-
join(): Argument #2 ($array) must be of type array, string given
139+
join(): Argument #2 ($array) must be of type ?array, string given
140140
-- Iteration 19 --
141-
join(): Argument #2 ($array) must be of type array, null given
141+
join(): If argument #1 ($separator) is of type string, argument #2 ($array) must be of type array, null given
142142
-- Iteration 20 --
143-
join(): Argument #2 ($array) must be of type array, null given
143+
join(): If argument #1 ($separator) is of type string, argument #2 ($array) must be of type array, null given
144144
-- Iteration 21 --
145-
join(): Argument #2 ($array) must be of type array, resource given
145+
join(): Argument #2 ($array) must be of type ?array, resource given
146146
-- Iteration 22 --
147-
join(): Argument #2 ($array) must be of type array, null given
147+
join(): If argument #1 ($separator) is of type string, argument #2 ($array) must be of type array, null given
148148
-- Iteration 23 --
149-
join(): Argument #2 ($array) must be of type array, null given
149+
join(): If argument #1 ($separator) is of type string, argument #2 ($array) must be of type array, null given
150150
Done

0 commit comments

Comments
 (0)