Fix memory leak when calling constructor manually

Author: Girgias

ext/reflection/php_reflection.c

@@ -1666,13 +1666,12 @@ ZEND_METHOD(ReflectionFunction, __construct)
 		}
 	}
 
-	// TODO How can this ever be hit?
-	//zval *object = ZEND_THIS;
-	//reflection_object *intern = Z_REFLECTION_P(object);
-	//if (intern->ptr) {
-	//	zval_ptr_dtor(&intern->obj);
-	//	zval_ptr_dtor(reflection_prop_name(object));
-	//}
+	/* If the constructor is manually called again we need to free the storage */
+	reflection_object *intern = Z_REFLECTION_P(ZEND_THIS);
+	if (intern->ptr) {
+		zval_ptr_dtor(&intern->obj);
+		zval_ptr_dtor(reflection_prop_name(ZEND_THIS));
+	}
 
 	reflection_function_create_common(fptr, closure_obj, ZEND_THIS);
 }

ext/reflection/tests/ReflectionFunction_construct_recall.phpt

@@ -0,0 +1,22 @@
+--TEST--
+ReflectionFunction constructor called manually after instantiation
+--FILE--
+<?php
+
+$fn1 = fn ($a) => $a . 'hello';
+
+$r = new ReflectionFunction($fn1);
+var_dump($r);
+$r->__construct('strpos');
+var_dump($r);
+
+?>
+--EXPECTF--
+object(ReflectionFunction)#2 (1) {
+  ["name"]=>
+  string(%d) "%s"
+}
+object(ReflectionFunction)#2 (1) {
+  ["name"]=>
+  string(6) "strpos"
+}