Review zend_is_true() usage in JIT

Girgias · Girgias · commit f9c567eb23f9 · 2020-09-23T16:47:16.000+01:00
diff --git a/ext/opcache/jit/zend_jit_x86.dasc b/ext/opcache/jit/zend_jit_x86.dasc
@@ -7978,6 +7978,7 @@ static int zend_jit_bool_jmpznz(dasm_State **Dst, const zend_op *opline, uint32_
 	}
 
 	if (Z_MODE(op1_addr) == IS_CONST_ZVAL) {
+	    /* zend_is_true() cannot fail as op1 cannot be an object */
 		if (zend_is_true(Z_ZV(op1_addr))) {
 			/* Always TRUE */
 			if (set_bool) {

Original file line number	Diff line number	Diff line change
`@@ -7978,6 +7978,7 @@ static int zend_jit_bool_jmpznz(dasm_State *Dst, const zend_op opline, uint32_`
`7978`	`7978`	`}`
`7979`	`7979`
`7980`	`7980`	`if (Z_MODE(op1_addr) == IS_CONST_ZVAL) {`
	`7981`	`+ /* zend_is_true() cannot fail as op1 cannot be an object */`
`7981`	`7982`	`if (zend_is_true(Z_ZV(op1_addr))) {`
`7982`	`7983`	`/* Always TRUE */`
`7983`	`7984`	`if (set_bool) {`