Skip to content

Commit fe185fb

Browse files
committed
mem leak for windows ?
1 parent 4335e31 commit fe185fb

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

ext/readline/readline.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,13 @@ PHP_FUNCTION(readline_info)
193193
strcpy(rl_line_buffer, Z_STRVAL_P(value));
194194
rl_end = Z_STRLEN_P(value);
195195
#else
196-
rl_line_buffer = strdup(Z_STRVAL_P(value));
196+
char *tmp = strdup(Z_STRVAL_P(value));
197+
if (tmp) {
198+
if (rl_line_buffer) {
199+
free(rl_line_buffer);
200+
}
201+
rl_line_buffer = tmp;
202+
}
197203
#endif
198204
}
199205
RETVAL_STRING(SAFE_STRING(oldstr));

0 commit comments

Comments
 (0)