Fix GH-12581 + more: [pdo_pgsql] Optimized the behavior of PDO::PARAM_XXX #12605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
force-pushed
the
optimize-pdo-param-pgsql
branch
from
9ce7d8c to
4200b32
Compare
SakiTakamachi
changed the title
|
I would like to hear from other drivers maintainers opinion on your ticket before jumping the gun there might be reasons behind those. |
|
Admittedly, I may have acted too early. The test has also failed, so I'll return it to the draft. |
|
Other drivers do not have code owners, so perhaps it would be better to discuss them on the mailing list. What do you think? |
Modify test DB attributes Fixed LOB handling
SakiTakamachi
force-pushed
the
optimize-pdo-param-pgsql
branch
from
4200b32 to
865774c
Compare
|
sure why not. |
|
Thank you, posted on mailing list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12581
This is related to #12603
I start with pdo_pgsql.
I consider this to be a bug fix, but I'm targeting the master branch due to its high impact.