Merge pull request #153 from sunil-cote/master

tareqtms · web-flow · commit a8ab4fda3087 · 2020-04-14T22:58:19.000+06:00
Added delete status of 204
diff --git a/lib/ShopifyResource.php b/lib/ShopifyResource.php
@@ -524,11 +524,12 @@ public function processResponse($responseArray, $dataKey = null)
             //Something went wrong, Checking HTTP Codes
             $httpOK = 200; //Request Successful, OK.
             $httpCreated = 201; //Create Successful.
+            $httpDeleted = 204; //Delete Successful
 
             //should be null if any other library used for http calls
             $httpCode = CurlRequest::$lastHttpCode;
 
-            if ($httpCode != null && $httpCode != $httpOK && $httpCode != $httpCreated) {
+            if ($httpCode != null && $httpCode != $httpOK && $httpCode != $httpCreated && $httpCode != $httpDeleted) {
                 throw new Exception\CurlException("Request failed with HTTP Code $httpCode.");
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -524,11 +524,12 @@ public function processResponse($responseArray, $dataKey = null)`
`524`	`524`	`//Something went wrong, Checking HTTP Codes`
`525`	`525`	`$httpOK = 200; //Request Successful, OK.`
`526`	`526`	`$httpCreated = 201; //Create Successful.`
	`527`	`+ $httpDeleted = 204; //Delete Successful`
`527`	`528`
`528`	`529`	`//should be null if any other library used for http calls`
`529`	`530`	`$httpCode = CurlRequest::$lastHttpCode;`
`530`	`531`
`531`		`- if ($httpCode != null && $httpCode != $httpOK && $httpCode != $httpCreated) {`
	`532`	`+ if ($httpCode != null && $httpCode != $httpOK && $httpCode != $httpCreated && $httpCode != $httpDeleted) {`
`532`	`533`	`throw new Exception\CurlException("Request failed with HTTP Code $httpCode.");`
`533`	`534`	`}`
`534`	`535`	`}`