Allow promoted properties in trait __construct even when renamed

Author: ondrejmirtes

src/Rules/Classes/InvalidPromotedPropertiesRule.php

@@ -61,7 +61,9 @@ public function processNode(Node $node, Scope $scope): array
 
 		if (
 			!$node instanceof Node\Stmt\ClassMethod
-			|| $node->name->toLowerString() !== '__construct'
+			|| (
+				$node->name->toLowerString() !== '__construct'
+				&& $node->getAttribute('originalTraitMethodName') !== '__construct')
 		) {
 			return [
 				RuleErrorBuilder::message(

tests/PHPStan/Rules/Classes/InvalidPromotedPropertiesRuleTest.php

@@ -5,6 +5,7 @@
 use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<InvalidPromotedPropertiesRule>
@@ -93,4 +94,14 @@ public function testSupportedOnPhp8(): void
 		]);
 	}
 
+	public function testBug9577(): void
+	{
+		if (PHP_VERSION_ID < 80100) {
+			$this->markTestSkipped('Test requires PHP 8.1.');
+		}
+
+		$this->phpVersion = 80100;
+		$this->analyse([__DIR__ . '/data/bug-9577.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Classes/data/bug-9577.php

@@ -0,0 +1,26 @@
+<?php // lint >= 8.1
+
+namespace Bug9577;
+
+trait StringableMessageTrait
+{
+	public function __construct(
+		public readonly string $message,
+	) {
+
+	}
+}
+
+class SpecializedException
+{
+	use StringableMessageTrait {
+		StringableMessageTrait::__construct as __traitConstruct;
+	}
+
+	public function __construct(
+		public int $code,
+		string $message,
+	) {
+		$this->__traitConstruct($message);
+	}
+}