Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Commit 4c19122

Browse files
committed
change test and tweak code
1 parent 82c8763 commit 4c19122

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/fragments/Slider.react.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ export default class Slider extends Component {
1717
? createSliderWithTooltip(ReactSlider)
1818
: ReactSlider;
1919
this._computeStyle = computeSliderStyle();
20-
this.state = {
21-
value: props.value
22-
};
20+
this.state = {value: props.value};
2321
}
2422

2523
UNSAFE_componentWillReceiveProps(newProps) {
@@ -35,8 +33,10 @@ export default class Slider extends Component {
3533
}
3634

3735
UNSAFE_componentWillMount() {
38-
this.props.setProps({drag_value: this.props.value});
39-
this.setState({value: this.props.value});
36+
if (this.props.value !== null) {
37+
this.props.setProps({drag_value: this.props.value});
38+
this.setState({value: this.props.value});
39+
}
4040
}
4141

4242
render() {

tests/integration/sliders/test_sliders.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,8 @@ def update_output(value):
189189

190190
dash_dcc.start_server(app)
191191
dash_dcc.wait_for_text_to_equal("#out-value", "You have selected 5")
192-
assert dash_dcc.find_element("#out-drag-value").text == "You have dragged 5"
192+
#assert dash_dcc.find_element("#out-drag-value").text == "You have dragged 5"
193+
dash_dcc.wait_for_text_to_equal("#out-drag-value", "You have dragged 5")
193194

194195
slider = dash_dcc.find_element("#slider")
195196
dash_dcc.click_and_hold_at_coord_fractions(slider, 0.25, 0.25)

0 commit comments

Comments
 (0)