Issue 681 - Upgrade plotly.js to 1.50.1 (#682)

Author: Marc-Andre-Rivet

CHANGELOG.md

@@ -2,6 +2,14 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [Unreleased]
+### Updated
+- Upgraded plotly.js to 1.50.1 [#681](https://github.com/plotly/dash-core-components/issues/681)
+  - Patch release [1.50.1](https://github.com/plotly/plotly.js/releases/tag/v1.50.1) containing several bug fixes.
+
+### Fixed
+- [#681](https://github.com/plotly/dash-core-components/issues/681) Fix a bug with the dcc.Graph component logging errors in certain circumstances when nested inside a dcc.Loading component
+
 ## [1.3.0] - 2019-10-08
 ### Added
 - Added `search_value` prop to `Dropdown`, for server-side options loading/filtering. [#660](https://github.com/plotly/dash-core-components/pull/660)

dash_core_components_base/__init__.py

@@ -42,8 +42,8 @@
 
 _js_dist = [
     {
-        'external_url': 'https://cdn.plot.ly/plotly-1.50.0.min.js',
-        'relative_package_path': 'plotly-1.50.0.min.js',
+        'external_url': 'https://cdn.plot.ly/plotly-1.50.1.min.js',
+        'relative_package_path': 'plotly-1.50.1.min.js',
         'namespace': 'dash_core_components'
     },
     {

dash_core_components_base/plotly-1.50.0.min.js renamed to dash_core_components_base/plotly-1.50.1.min.js

@@ -220,7 +220,9 @@ class PlotlyGraph extends Component {
         const gd = this.gd.current;
         if (gd && gd.removeAllListeners) {
             gd.removeAllListeners();
-            Plotly.purge(gd);
+            if (this._hasPlotted) {
+                Plotly.purge(gd);
+            }
         }
         window.removeEventListener('resize', this.graphResize);
     }

src/components/Graph.react.js

@@ -88,3 +88,48 @@ def selected_df_figure(selection):
     # but that's what we had as of the 608 fix, PR 621, so let's lock that
     # in for now.
     assert call_count.value == 2
+
+
+@pytest.mark.DCC672
+def test_grbs002_graph_wrapped_in_loading_component_does_not_fail(dash_dcc):
+    app = dash.Dash(__name__, suppress_callback_exceptions=True)
+    app.layout = html.Div([
+        html.H1('subplot issue'),
+        dcc.Location(id='url', refresh=False),
+        dcc.Loading(id="page-content")
+    ])
+
+    @app.callback(Output('page-content', 'children'), [Input('url', 'value')])
+    def render_page(url):
+        return [
+            dcc.Dropdown(
+                id='my-dropdown',
+                options=[
+                    {'label': 'option 1', 'value': '1'},
+                    {'label': 'option 2', 'value': '2'}
+                ],
+                value='1'
+            ),
+            dcc.Graph(id='my-graph')
+        ]
+
+    @app.callback(Output('my-graph', 'figure'), [Input('my-dropdown', 'value')])
+    def update_graph(value):
+        values = [1, 2, 3]
+        ranges = [1, 2, 3]
+
+        return {
+            'data': [{
+                'x': ranges,
+                'y': values,
+                'line': {
+                    'shape': 'spline'
+                }
+            }],
+        }
+
+    dash_dcc.start_server(app)
+
+    dash_dcc.wait_for_element('#my-graph .main-svg')
+
+    assert not dash_dcc.get_logs()