Skip to content

Commit 09f551a

Browse files
authored
Merge pull request #443 from plotly/fix-registered-path
Change registered_paths to a `collections.defaultdict(set)`.
2 parents 61b0545 + 229978b commit 09f551a

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.28.6 - 2018-11-05
2+
## Fixed
3+
- `Dash.registered_paths` changed to a `collections.defaultdict(set)`, was appending the same package paths on every index. [#443](https://github.com/plotly/dash/pull/443)
4+
15
## 0.28.5 - 2018-10-18
26
## Fixed
37
- Replace windows endline when generating the components classes docstring [#431](https://github.com/plotly/dash/pull/431)

dash/dash.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def _handle_error(error):
167167

168168
self.assets_ignore = assets_ignore
169169

170-
self.registered_paths = {}
170+
self.registered_paths = collections.defaultdict(set)
171171

172172
# urls
173173
self.routes = []
@@ -313,10 +313,7 @@ def _collect_and_register_resources(self, resources):
313313
def _relative_url_path(relative_package_path='', namespace=''):
314314

315315
# track the registered packages
316-
if namespace in self.registered_paths:
317-
self.registered_paths[namespace].append(relative_package_path)
318-
else:
319-
self.registered_paths[namespace] = [relative_package_path]
316+
self.registered_paths[namespace].add(relative_package_path)
320317

321318
module_path = os.path.join(
322319
os.path.dirname(sys.modules[namespace].__file__),

dash/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '0.28.5'
1+
__version__ = '0.28.6'

0 commit comments

Comments
 (0)