ggplotly: comment about margin sizes correctness

alyst · alyst · commit efaeebf5b7b9 · 2016-06-06T00:49:39.000+02:00
diff --git a/R/ggplotly.R b/R/ggplotly.R
@@ -345,6 +345,9 @@ gg2list <- function(p, width = NULL, height = NULL, tooltip = "all", source = "A
         bbox(lab, axisTextY$angle, unitConvert(axisTextY, "npc", "width"))[["width"]]
     }
   }
+  # FIXME left/right top/left subplot margins are summed in get_domains, do we need them both?
+  # FIXME using rep() gives double-sized margins in dom, but somehow this bug is covered by
+  #       the same effect as offset hack below
   margins <- c(
     rep(panelMarginX, 2),
     rep(panelMarginY, 2)

Original file line number	Diff line number	Diff line change
`@@ -345,6 +345,9 @@ gg2list <- function(p, width = NULL, height = NULL, tooltip = "all", source = "A`
`345`	`345`	`bbox(lab, axisTextY$angle, unitConvert(axisTextY, "npc", "width"))[["width"]]`
`346`	`346`	`}`
`347`	`347`	`}`
	`348`	`+ # FIXME left/right top/left subplot margins are summed in get_domains, do we need them both?`
	`349`	`+ # FIXME using rep() gives double-sized margins in dom, but somehow this bug is covered by`
	`350`	`+ # the same effect as offset hack below`
`348`	`351`	`margins <- c(`
`349`	`352`	`rep(panelMarginX, 2),`
`350`	`353`	`rep(panelMarginY, 2)`