Skip to content

Commit 019bacf

Browse files
committed
AJ-proof legacy polar depreaction warnings
1 parent f32b398 commit 019bacf

File tree

3 files changed

+20
-10
lines changed

3 files changed

+20
-10
lines changed

src/plots/polar/legacy/area_attributes.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,24 @@ var scatterAttrs = require('../../../traces/scatter/attributes');
1212
var scatterMarkerAttrs = scatterAttrs.marker;
1313
var extendFlat = require('../../../lib/extend').extendFlat;
1414

15-
var deprecationWarning = 'Area traces are deprecated!';
15+
var deprecationWarning = [
16+
'Area traces are deprecated!',
17+
'Please switch to the *barpolar* trace type.'
18+
].join(' ');
1619

1720
module.exports = {
1821
r: extendFlat({}, scatterAttrs.r, {
1922
description: [
2023
deprecationWarning,
21-
scatterAttrs.r.description
24+
'Sets the radial coordinates',
25+
'for legacy polar chart only.'
2226
].join(' ')
2327
}),
2428
t: extendFlat({}, scatterAttrs.t, {
2529
description: [
2630
deprecationWarning,
27-
scatterAttrs.t.description
31+
'Sets the angular coordinates',
32+
'for legacy polar chart only.'
2833
].join(' ')
2934
}),
3035
marker: {

src/plots/polar/legacy/axis_attributes.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ var axesAttrs = require('../../cartesian/layout_attributes');
1313
var extendFlat = require('../../../lib/extend').extendFlat;
1414
var overrideAll = require('../../../plot_api/edit_types').overrideAll;
1515

16-
var deprecationWarning = 'Legacy polar charts are deprecated!';
16+
var deprecationWarning = [
17+
'Legacy polar charts are deprecated!',
18+
'Please switch to *polar* subplots.'
19+
].join(' ');
1720

1821
var domainAttr = extendFlat({}, axesAttrs.domain, {
1922
description: [

src/traces/scatter/attributes.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -544,18 +544,20 @@ module.exports = {
544544
valType: 'data_array',
545545
editType: 'calc',
546546
description: [
547-
'For legacy polar chart only.',
548-
'Please switch to *scatterpolar* trace type.',
549-
'Sets the radial coordinates.'
547+
'r coordinates in scatter traces are deprecated!',
548+
'Please switch to the *scatterpolar* trace type.',
549+
'Sets the radial coordinates',
550+
'for legacy polar chart only.'
550551
].join('')
551552
},
552553
t: {
553554
valType: 'data_array',
554555
editType: 'calc',
555556
description: [
556-
'For legacy polar chart only.',
557-
'Please switch to *scatterpolar* trace type.',
558-
'Sets the angular coordinates.'
557+
't coordinates in scatter traces are deprecated!',
558+
'Please switch to the *scatterpolar* trace type.',
559+
'Sets the angular coordinates',
560+
'for legacy polar chart only.'
559561
].join('')
560562
}
561563
};

0 commit comments

Comments
 (0)