Skip to content

Commit 2485ff4

Browse files
committed
lint: mostly un-tersing some ternaries
1 parent 7ae437b commit 2485ff4

File tree

4 files changed

+10
-23
lines changed

4 files changed

+10
-23
lines changed

src/components/colorscale/calc.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ module.exports = function calc(trace, vals, containerStr, cLetter) {
2121
if(containerStr) {
2222
container = Lib.nestedProperty(trace, containerStr).get();
2323
inputContainer = Lib.nestedProperty(trace._input, containerStr).get();
24-
} else {
24+
}
25+
else {
2526
container = trace;
2627
inputContainer = trace._input;
2728
}

src/traces/scatter/colorscale_calc.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,15 @@ var calcColorscale = require('../../components/colorscale/calc');
1515
var subTypes = require('./subtypes');
1616

1717

18-
// common to 'scatter', 'scatter3d' and 'scattergeo'
1918
module.exports = function calcMarkerColorscale(trace) {
20-
21-
// auto-z and autocolorscale if applicable
22-
2319
if(subTypes.hasLines(trace) && hasColorscale(trace, 'line')) {
2420
calcColorscale(trace, trace.line.color, 'line', 'c');
2521
}
2622

2723
if(subTypes.hasMarkers(trace)) {
28-
2924
if(hasColorscale(trace, 'marker')) {
3025
calcColorscale(trace, trace.marker.color, 'marker', 'c');
3126
}
32-
3327
if(hasColorscale(trace, 'marker.line')) {
3428
calcColorscale(trace, trace.marker.line.color, 'marker.line', 'c');
3529
}

src/traces/scatter/line_defaults.js

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,18 @@ var hasColorscale = require('../../components/colorscale/has_colorscale');
1313
var colorscaleDefaults = require('../../components/colorscale/defaults');
1414

1515

16-
// common to 'scatter', 'scatter3d', 'scattergeo' and 'scattergl'
1716
module.exports = function lineDefaults(traceIn, traceOut, defaultColor, layout, coerce) {
18-
1917
var markerColor = (traceIn.marker || {}).color;
2018

2119
coerce('line.color', defaultColor);
20+
2221
if(hasColorscale(traceIn, 'line')) {
23-
colorscaleDefaults(
24-
traceIn, traceOut, layout, coerce, {prefix: 'line.', cLetter: 'c'}
25-
);
26-
} else {
27-
coerce('line.color', (Array.isArray(markerColor) ? false : markerColor) ||
28-
defaultColor);
22+
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: 'line.', cLetter: 'c'});
23+
}
24+
else {
25+
var lineColorDflt = (Array.isArray(markerColor) ? false : markerColor) || defaultColor;
26+
coerce('line.color', lineColorDflt);
2927
}
30-
3128

3229
coerce('line.width');
3330
coerce('line.dash');

src/traces/scatter/marker_defaults.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ var colorscaleDefaults = require('../../components/colorscale/defaults');
1616
var subTypes = require('./subtypes');
1717

1818

19-
// common to 'scatter', 'scatter3d', 'scattergeo' and 'scattergl'
2019
module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout, coerce) {
2120
var isBubble = subTypes.isBubble(traceIn),
2221
lineColor = !Array.isArray(traceIn.line) ? (traceIn.line || {}).color : undefined,
@@ -30,9 +29,7 @@ module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout
3029

3130
coerce('marker.color', defaultColor);
3231
if(hasColorscale(traceIn, 'marker')) {
33-
colorscaleDefaults(
34-
traceIn, traceOut, layout, coerce, {prefix: 'marker.', cLetter: 'c'}
35-
);
32+
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: 'marker.', cLetter: 'c'});
3633
}
3734

3835
// if there's a line with a different color than the marker, use
@@ -46,9 +43,7 @@ module.exports = function markerDefaults(traceIn, traceOut, defaultColor, layout
4643

4744
coerce('marker.line.color', defaultMLC);
4845
if(hasColorscale(traceIn, 'marker.line')) {
49-
colorscaleDefaults(
50-
traceIn, traceOut, layout, coerce, {prefix: 'marker.line.', cLetter: 'c'}
51-
);
46+
colorscaleDefaults(traceIn, traceOut, layout, coerce, {prefix: 'marker.line.', cLetter: 'c'});
5247
}
5348

5449
coerce('marker.line.width', isBubble ? 1 : 0);

0 commit comments

Comments
 (0)