fixup pad autorange (again)

Author: etpinard

src/plots/gl3d/scene.js

@@ -508,7 +508,7 @@ proto.plot = function(sceneData, fullLayout, layout) {
                 var obj = objects[j];
                 var objBounds = obj.bounds;
                 var fullTrace = obj._trace.data;
-                var pad = fullTrace._pad ? fullTrace._pad / dataScale[i] : 0;
+                var pad = fullTrace._pad || 0;
 
                 sceneBounds[0][i] = Math.min(sceneBounds[0][i], objBounds[0][i] / dataScale[i] - pad);
                 sceneBounds[1][i] = Math.max(sceneBounds[1][i], objBounds[1][i] / dataScale[i] + pad);

src/traces/cone/calc.js

@@ -36,7 +36,9 @@ module.exports = function calc(gd, trace) {
     // stash max norm value to convert cmix/cmax -> vertexIntensityBounds
     trace._normMax = normMax;
     // stash autorange pad using max 'component' value
-    trace._pad = Math.sqrt(compMax) / (normMax || 1);
+    trace._pad = trace.sizemode === 'absolute' ?
+        trace.sizeref :
+        2 * (Math.sqrt(compMax) / (normMax || 1)) * trace.sizeref;
 
     colorscaleCalc(trace, [normMin, normMax], '', 'c');
 };

test/image/baselines/gl3d_cone-autorange.png

@@ -60,7 +60,7 @@ describe('Test cone defaults', function() {
     });
 });
 
-describe('@gl Test cone autorange', function() {
+describe('@gl Test cone autorange:', function() {
     var gd;
 
     beforeEach(function() {
@@ -117,6 +117,55 @@ describe('@gl Test cone autorange', function() {
             _assertAxisRanges('scaled down',
                 [-0.39, 4.39], [-0.39, 4.39], [-0.39, 4.39]
             );
+
+            var trace = fig.data[0];
+
+            var x = trace.x.slice();
+            x.push(5);
+            var y = trace.y.slice();
+            y.push(5);
+            var z = trace.z.slice();
+            z.push(5);
+            var u = trace.u.slice();
+            u.push(0);
+            var v = trace.v.slice();
+            v.push(0);
+            var w = trace.w.slice();
+            w.push(0);
+
+            return Plotly.restyle(gd, {
+                x: [x], y: [y], z: [z],
+                u: [u], v: [v], w: [w]
+            });
+        })
+        .then(function() {
+            _assertAxisRanges('after adding one cone outside range but with norm-0',
+                [-0.45, 6.45], [-0.45, 6.45], [-0.45, 6.45]
+            );
+
+            return Plotly.restyle(gd, 'sizeref', 10);
+        })
+        .then(function() {
+            _assertAxisRanges('after increasing sizeref',
+                [-12.4, 18.4], [-12.4, 18.4], [-12.4, 18.4]
+            );
+
+            return Plotly.restyle(gd, 'sizeref', 0.1);
+        })
+        .then(function() {
+            _assertAxisRanges('after decreasing sizeref',
+                [0.74, 5.26], [0.74, 5.26], [0.74, 5.26]
+            );
+
+            return Plotly.restyle(gd, {
+                sizemode: 'absolute',
+                sizeref: 2
+            });
+        })
+        .then(function() {
+            _assertAxisRanges('with sizemode absolute',
+                [-1.25, 7.25], [-1.25, 7.25], [-1.25, 7.25]
+            );
         })
         .catch(failTest)
         .then(done);