add 'sizeref'

... using @kig's work from
    gl-vis/gl-streamtube3d#3

Author: etpinard

package-lock.json

@@ -83,7 +83,7 @@
     "gl-select-box": "^1.0.2",
     "gl-spikes2d": "^1.0.1",
     "gl-surface3d": "^1.3.4",
-    "gl-streamtube3d": "[email protected]:gl-vis/gl-streamtube3d#a56d653657f0c7cef4fd338318ba69d908a8ce1f",
+    "gl-streamtube3d": "[email protected]:gl-vis/gl-streamtube3d#97c89d7d0e4e4ed1074d47fbfc715bb2d149841c",
     "glslify": "^6.1.1",
     "has-hover": "^1.0.1",
     "has-passive-events": "^1.0.0",

package.json

@@ -79,7 +79,15 @@ var attrs = {
 
     // TODO
     // maxLength
-    // widthScale
+
+    sizeref: {
+        valType: 'number',
+        role: 'info',
+        editType: 'calc',
+        min: 0,
+        dflt: 1,
+        description: ''
+    },
 
     text: {
         valType: 'string',

src/traces/streamtube/attributes.js

@@ -84,10 +84,8 @@ function convert(scene, trace) {
 
     // TODO
     // tubeOpts.maxLength
-    // tubeOpts.widthScale
 
-    // TODO the widhScale default looks BRUTAL
-    tubeOpts.widthScale = 100;
+    tubeOpts.tubeSize = trace.sizeref;
 
     var xbnds = toDataCoords(trace._xbnds, 'xaxis');
     var ybnds = toDataCoords(trace._ybnds, 'yaxis');
@@ -99,12 +97,9 @@ function convert(scene, trace) {
 
     var meshData = tube2mesh(tubeOpts, bounds);
 
-    // TODO cmin/cmax correspond to the min/max vector norm
+    // N.B. cmin/cmax correspond to the min/max vector norm
     // in the u/v/w arrays, which in general is NOT equal to max
     // intensity that colors the tubes.
-    //
-    // Maybe we should use meshData.vertexIntensities instead to
-    // determine the auto values for "cmin" and "cmax"?
     meshData.vertexIntensityBounds = [trace.cmin, trace.cmax];
 
     // pass gl-mesh3d lighting attributes

src/traces/streamtube/convert.js

@@ -42,7 +42,9 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
 
     // TODO adapt these
     // coerce('maxLength');
-    // coerce('widthScale');
+    // coerce('sizemode');
+
+    coerce('sizeref');
 
     coerce('lighting.ambient');
     coerce('lighting.diffuse');