use constant _hoverd.marker.line.width - improve a treemap mock and use a darker color

Author: archmoj

src/traces/sunburst/fx.js

@@ -180,7 +180,9 @@ module.exports = function attachFxHandlers(sliceTop, entry, gd, cd, opts) {
 
         if(isTreemap) {
             var slice = sliceTop.select('path.surface');
-            opts.styleOne(slice, pt, traceNow, true);
+            opts.styleOne(slice, pt, traceNow, {
+                hovered: true
+            });
         }
 
         trace._hasHoverEvent = true;
@@ -211,7 +213,9 @@ module.exports = function attachFxHandlers(sliceTop, entry, gd, cd, opts) {
 
         if(isTreemap) {
             var slice = sliceTop.select('path.surface');
-            opts.styleOne(slice, pt, traceNow, false);
+            opts.styleOne(slice, pt, traceNow, {
+                hovered: false
+            });
         }
     };
 

src/traces/treemap/defaults.js

@@ -48,7 +48,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     }
 
     coerce('tiling.flip');
-    var tilingPad = coerce('tiling.pad');
+    coerce('tiling.pad');
 
     var text = coerce('text');
     coerce('texttemplate');
@@ -90,8 +90,9 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
 
     traceOut._hovered = {
         marker: {
+            opacity: 1,
             line: {
-                width: Math.max(tilingPad, 2),
+                width: 2,
                 color: Color.contrast(layout.paper_bgcolor)
             }
         }

src/traces/treemap/draw_ancestors.js

@@ -130,7 +130,9 @@ module.exports = function drawAncestors(gd, cd, entry, slices, opts) {
                 isTransitioning: gd._transitioning
             });
 
-        slicePath.call(styleOne, pt, trace);
+        slicePath.call(styleOne, pt, trace, {
+            hovered: false
+        });
 
         var sliceTextGroup = Lib.ensureSingle(sliceTop, 'g', 'slicetext');
         var sliceText = Lib.ensureSingle(sliceTextGroup, 'text', '', function(s) {

src/traces/treemap/draw_descendants.js

@@ -128,7 +128,9 @@ module.exports = function drawDescendants(gd, cd, entry, slices, opts) {
             })
             .call(helpers.setSliceCursor, gd, { isTransitioning: gd._transitioning });
 
-        slicePath.call(styleOne, pt, trace);
+        slicePath.call(styleOne, pt, trace, {
+            hovered: false
+        });
 
         var sliceTextGroup = Lib.ensureSingle(sliceTop, 'g', 'slicetext');
         var sliceText = Lib.ensureSingle(sliceTextGroup, 'text', '', function(s) {

src/traces/treemap/style.js

@@ -21,22 +21,24 @@ function style(gd) {
         gTrace.style('opacity', trace.opacity);
 
         gTrace.selectAll('path.surface').each(function(pt) {
-            d3.select(this).call(styleOne, pt, trace);
+            d3.select(this).call(styleOne, pt, trace, {
+                hovered: false
+            });
         });
     });
 }
 
-function styleOne(s, pt, trace, hovered) {
+function styleOne(s, pt, trace, opts) {
     var cdi = pt.data.data;
     var ptNumber = cdi.i;
     var lineColor;
     var lineWidth;
     var opacity;
 
-    if(hovered) {
+    if((opts || {}).hovered) {
         lineColor = trace._hovered.marker.line.color;
         lineWidth = trace._hovered.marker.line.width;
-        opacity = 1;
+        opacity = trace._hovered.marker.opacity;
     } else {
         lineColor = Lib.castOption(trace, ptNumber, 'marker.line.color') || Color.defaultLine;
         lineWidth = Lib.castOption(trace, ptNumber, 'marker.line.width') || 0;

test/image/baselines/treemap_textposition.png

@@ -977,6 +977,7 @@
     "layout": {
         "width": 1200,
         "height": 1200,
+        "paper_bgcolor": "#210",
         "annotations": [
             {
                 "showarrow": false,