Skip to content

Commit f9494b5

Browse files
committed
Fix modebar Jasmine tests involving selectable traces [1852]
- Reason: mocking of `gd._fullData._module` was missing the `selectable` property introduced a few commits earlier to centralize checking if a trace supports selection.
1 parent c4012e1 commit f9494b5

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

test/jasmine/tests/modebar_test.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ describe('ModeBar', function() {
356356
type: 'scatter',
357357
visible: true,
358358
mode: 'markers',
359-
_module: {getPointsIn: true, toggleSelected: true}
359+
_module: {selectable: true}
360360
}];
361361

362362
manageModeBar(gd);
@@ -380,7 +380,7 @@ describe('ModeBar', function() {
380380
type: 'box',
381381
visible: true,
382382
boxpoints: 'all',
383-
_module: {getPointsIn: true, toggleSelected: true}
383+
_module: {selectable: true}
384384
}];
385385

386386
manageModeBar(gd);
@@ -452,7 +452,7 @@ describe('ModeBar', function() {
452452
type: 'scattergeo',
453453
visible: true,
454454
mode: 'markers',
455-
_module: {getPointsIn: true, toggleSelected: true}
455+
_module: {selectable: true}
456456
}];
457457

458458
manageModeBar(gd);
@@ -492,7 +492,7 @@ describe('ModeBar', function() {
492492
type: 'scatter',
493493
visible: true,
494494
mode: 'markers',
495-
_module: {getPointsIn: true, toggleSelected: true}
495+
_module: {selectable: true}
496496
}];
497497

498498
manageModeBar(gd);
@@ -584,7 +584,7 @@ describe('ModeBar', function() {
584584
type: 'scatter',
585585
visible: true,
586586
mode: 'markers',
587-
_module: {getPointsIn: true, toggleSelected: true}
587+
_module: {selectable: true}
588588
}];
589589

590590
manageModeBar(gd);
@@ -606,7 +606,7 @@ describe('ModeBar', function() {
606606
type: 'scatter',
607607
visible: true,
608608
mode: 'markers',
609-
_module: {getPointsIn: true, toggleSelected: true}
609+
_module: {selectable: true}
610610
}];
611611
gd._fullLayout.xaxis = {fixedrange: false};
612612
gd._fullLayout._basePlotModules = [{ name: 'cartesian' }, { name: 'pie' }];
@@ -662,7 +662,7 @@ describe('ModeBar', function() {
662662
type: 'scatterternary',
663663
visible: true,
664664
mode: 'markers',
665-
_module: {getPointsIn: true, toggleSelected: true}
665+
_module: {selectable: true}
666666
}];
667667
gd._fullLayout._basePlotModules = [{ name: 'ternary' }];
668668

0 commit comments

Comments
 (0)