Make TimelineItem-badge--success ready for V2 (#1475)

simurai · web-flow · commit 105296c6b4b3 · 2021-06-28T20:43:51.000+09:00
* Use btn-primary-text for TimelineItem-badge--success

* Use emphasis color

* Create silent-cycles-camp.md
diff --git a/.changeset/silent-cycles-camp.md b/.changeset/silent-cycles-camp.md
@@ -0,0 +1,5 @@
+---
+"@primer/css": patch
+---
+
+Make `TimelineItem-badge--success` ready for Color Modes V2
diff --git a/src/timeline/timeline-item.scss b/src/timeline/timeline-item.scss
@@ -42,8 +42,8 @@
   flex-shrink: 0;
 
   &--success {
-    color: var(--color-text-white);
-    background-color: var(--color-btn-primary-bg);
+    color: var(--color-fg-on-emphasis, var(--color-btn-primary-text)); // TODO remove V1 fallback
+    background-color: var(--color-success-emphasis, var(--color-btn-primary-bg)); // TODO remove V1 fallback
     border: $border-width $border-style var(--color-timeline-badge-success-border);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,8 @@`
`42`	`42`	`flex-shrink: 0;`
`43`	`43`
`44`	`44`	`&--success {`
`45`		`- color: var(--color-text-white);`
`46`		`- background-color: var(--color-btn-primary-bg);`
	`45`	`+ color: var(--color-fg-on-emphasis, var(--color-btn-primary-text)); // TODO remove V1 fallback`
	`46`	`+ background-color: var(--color-success-emphasis, var(--color-btn-primary-bg)); // TODO remove V1 fallback`
`47`	`47`	`border: $border-width $border-style var(--color-timeline-badge-success-border);`
`48`	`48`	`}`
`49`	`49`	`}`