Skip to content

Commit 6a83a92

Browse files
authored
Add open and closed color roles (#1948)
* Add `open` and `closed` color role * Use new open/closed color variables * yarn add @primer/[email protected] This is just temporarily to test the docs * Add `Label--open` and `Label--closed` * Create clever-bugs-love.md * yarn add @primer/[email protected] * yarn add @primer/[email protected]
1 parent 80bf9d9 commit 6a83a92

File tree

10 files changed

+60
-9
lines changed

10 files changed

+60
-9
lines changed

.changeset/clever-bugs-love.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/css": minor
3+
---
4+
5+
Add `open` and `closed` color roles

docs/content/components/labels.md

+4
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ Labels come in a few different functional classes. Use to communicate the conten
4242
- `Label--attention`
4343
- `Label--severe`
4444
- `Label--danger`
45+
- `Label--open`
46+
- `Label--closed`
4547
- `Label--done`
4648
- `Label--sponsors`
4749

@@ -51,6 +53,8 @@ Labels come in a few different functional classes. Use to communicate the conten
5153
<span class="Label mr-1 Label--attention">Attention</span>
5254
<span class="Label mr-1 Label--severe">Severe</span>
5355
<span class="Label mr-1 Label--danger">Danger</span>
56+
<span class="Label mr-1 Label--open">Open</span>
57+
<span class="Label mr-1 Label--closed">Closed</span>
5458
<span class="Label mr-1 Label--done">Done</span>
5559
<span class="Label mr-1 Label--sponsors">Sponsors</span>
5660
```

docs/content/utilities/colors.mdx

+14
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ Use text color utilities to set text to a specific color. Color contrast must pa
2424
<div class="color-fg-attention mb-1">.color-fg-attention</div>
2525
<div class="color-fg-severe mb-1">.color-fg-severe</div>
2626
<div class="color-fg-danger mb-1">.color-fg-danger</div>
27+
<div class="color-fg-open mb-1">.color-fg-open</div>
28+
<div class="color-fg-closed mb-1">.color-fg-closed</div>
2729
<div class="color-fg-done mb-1">.color-fg-done</div>
2830
<div class="color-fg-sponsors mb-4">.color-fg-sponsors</div>
2931

@@ -62,6 +64,12 @@ Background colors are most commonly used for filling large blocks of content or
6264
<div class="color-bg-danger p-2 rounded mb-2">.color-bg-danger</div>
6365
<div class="color-bg-danger-emphasis color-fg-on-emphasis p-2 rounded mb-4">.color-bg-danger-emphasis</div>
6466

67+
<div class="color-bg-open p-2 rounded mb-2">.color-bg-open</div>
68+
<div class="color-bg-open-emphasis color-fg-on-emphasis p-2 rounded mb-4">.color-bg-open-emphasis</div>
69+
70+
<div class="color-bg-closed p-2 rounded mb-2">.color-bg-closed</div>
71+
<div class="color-bg-closed-emphasis color-fg-on-emphasis p-2 rounded mb-4">.color-bg-closed-emphasis</div>
72+
6573
<div class="color-bg-done p-2 rounded mb-2">.color-bg-done</div>
6674
<div class="color-bg-done-emphasis color-fg-on-emphasis p-2 rounded mb-4">.color-bg-done-emphasis</div>
6775

@@ -93,6 +101,12 @@ Override default border colors with the following utilities.
93101
<div class="border color-border-danger p-2 rounded mb-2">.color-border-danger</div>
94102
<div class="border color-border-danger-emphasis p-2 rounded mb-4">.color-border-danger-emphasis</div>
95103

104+
<div class="border color-border-open p-2 rounded mb-2">.color-border-open</div>
105+
<div class="border color-border-open-emphasis p-2 rounded mb-4">.color-border-open-emphasis</div>
106+
107+
<div class="border color-border-closed p-2 rounded mb-2">.color-border-closed</div>
108+
<div class="border color-border-closed-emphasis p-2 rounded mb-4">.color-border-closed-emphasis</div>
109+
96110
<div class="border color-border-done p-2 rounded mb-2">.color-border-done</div>
97111
<div class="border color-border-done-emphasis p-2 rounded mb-4">.color-border-done-emphasis</div>
98112

docs/src/stories/components/Label/Label.stories.jsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export default {
1313
}
1414
},
1515
variant: {
16-
options: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9], // iterator
16+
options: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11], // iterator
1717
mapping: [
1818
'',
1919
'Label--primary',
@@ -23,12 +23,14 @@ export default {
2323
'Label--attention',
2424
'Label--severe',
2525
'Label--danger',
26+
'Label--open',
27+
'Label--closed',
2628
'Label--done',
2729
'Label--sponsors'
2830
], // values
2931
control: {
3032
type: 'select',
31-
labels: ['default', 'primary', 'secondary', 'accent', 'success', 'attention', 'severe', 'danger', 'done', 'sponsors']
33+
labels: ['default', 'primary', 'secondary', 'accent', 'success', 'attention', 'severe', 'danger', 'open', 'closed', 'done', 'sponsors']
3234
},
3335
description: 'Colors',
3436
table: {

docs/src/stories/components/Label/LabelFeatures.stories.jsx

+2
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ export const AllVariants = ({}) => (
9595
<LabelTemplate text="Attention" variant="Label--attention" />
9696
<LabelTemplate text="Severe" variant="Label--severe" />
9797
<LabelTemplate text="Danger" variant="Label--danger" />
98+
<LabelTemplate text="Open" variant="Label--open" />
99+
<LabelTemplate text="Closed" variant="Label--closed" />
98100
<LabelTemplate text="Done" variant="Label--done" />
99101
<LabelTemplate text="Sponsors" variant="Label--sponsors" />
100102
</>

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"storybook": "cd docs && yarn && yarn storybook"
4040
},
4141
"dependencies": {
42-
"@primer/primitives": "^7.4.0"
42+
"@primer/primitives": "7.5.0"
4343
},
4444
"devDependencies": {
4545
"@changesets/changelog-github": "0.4.2",

src/labels/labels.scss

+10
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,16 @@
7171
border-color: var(--color-danger-emphasis);
7272
}
7373

74+
.Label--open {
75+
color: var(--color-open-fg);
76+
border-color: var(--color-open-emphasis);
77+
}
78+
79+
.Label--closed {
80+
color: var(--color-closed-fg);
81+
border-color: var(--color-closed-emphasis);
82+
}
83+
7484
.Label--done {
7585
color: var(--color-done-fg);
7686
border-color: var(--color-done-emphasis);

src/labels/states.scss

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929
.State--open {
3030
color: var(--color-fg-on-emphasis);
31-
background-color: var(--color-success-emphasis);
31+
background-color: var(--color-open-emphasis);
3232
}
3333

3434
.State--merged {
@@ -38,7 +38,7 @@
3838

3939
.State--closed {
4040
color: var(--color-fg-on-emphasis);
41-
background-color: var(--color-danger-emphasis);
41+
background-color: var(--color-closed-emphasis);
4242
}
4343

4444
// Small

src/utilities/colors.scss

+14
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
.color-fg-attention { color: var(--color-attention-fg) !important; }
1212
.color-fg-severe { color: var(--color-severe-fg) !important; }
1313
.color-fg-danger { color: var(--color-danger-fg) !important; }
14+
.color-fg-open { color: var(--color-open-fg) !important; }
15+
.color-fg-closed { color: var(--color-closed-fg) !important; }
1416
.color-fg-done { color: var(--color-done-fg) !important; }
1517
.color-fg-sponsors { color: var(--color-sponsors-fg) !important; }
1618

@@ -39,6 +41,12 @@
3941
.color-bg-danger { background-color: var(--color-danger-subtle) !important; }
4042
.color-bg-danger-emphasis { background-color: var(--color-danger-emphasis) !important; }
4143

44+
.color-bg-open { background-color: var(--color-open-subtle) !important; }
45+
.color-bg-open-emphasis { background-color: var(--color-open-emphasis) !important; }
46+
47+
.color-bg-closed { background-color: var(--color-closed-subtle) !important; }
48+
.color-bg-closed-emphasis { background-color: var(--color-closed-emphasis) !important; }
49+
4250
.color-bg-done { background-color: var(--color-done-subtle) !important; }
4351
.color-bg-done-emphasis { background-color: var(--color-done-emphasis) !important; }
4452

@@ -66,6 +74,12 @@
6674
.color-border-danger { border-color: var(--color-danger-muted) !important; }
6775
.color-border-danger-emphasis { border-color: var(--color-danger-emphasis) !important; }
6876

77+
.color-border-open { border-color: var(--color-open-muted) !important; }
78+
.color-border-open-emphasis { border-color: var(--color-open-emphasis) !important; }
79+
80+
.color-border-closed { border-color: var(--color-closed-muted) !important; }
81+
.color-border-closed-emphasis { border-color: var(--color-closed-emphasis) !important; }
82+
6983
.color-border-done { border-color: var(--color-done-muted) !important; }
7084
.color-border-done-emphasis { border-color: var(--color-done-emphasis) !important; }
7185

yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -1148,10 +1148,10 @@
11481148
"@nodelib/fs.scandir" "2.1.5"
11491149
fastq "^1.6.0"
11501150

1151-
"@primer/primitives@^7.4.0":
1152-
version "7.4.0"
1153-
resolved "https://registry.yarnpkg.com/@primer/primitives/-/primitives-7.4.0.tgz#75df54a80233a432b687c0e3010e4be6bd60a82d"
1154-
integrity sha512-gD6yHXN7YKox/bdUNgxhoSS/WXZVaORK1r4dOAyTrdoPrLV/ucIfRInPyVcTF+Mqr0zcTFJtiMtuA5Y8CSyOEg==
1151+
"@primer/primitives@7.5.0":
1152+
version "7.5.0"
1153+
resolved "https://registry.yarnpkg.com/@primer/primitives/-/primitives-7.5.0.tgz#c997637bc315b3fde6d1ed22031d60d24b04d85b"
1154+
integrity sha512-DNAGOxFvelUz2THCZNo1EuSRbtujhY7NR02WjQvSGlbBihMeMJ5yrUYgeQyo/OGrg+HlzbwLW56OLy9PN+iqXA==
11551155

11561156
"@primer/stylelint-config@^12.3.3":
11571157
version "12.3.3"

0 commit comments

Comments
 (0)