Skip to content

Commit c6e214b

Browse files
authored
Remove form-validation.scss (#2402)
* Move `.form-group label` * Remove `form-validation.scss` * Create .changeset/poor-hotels-roll.md * Lint
1 parent 85f31cc commit c6e214b

File tree

4 files changed

+7
-267
lines changed

4 files changed

+7
-267
lines changed

.changeset/poor-hotels-roll.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/css": major
3+
---
4+
5+
Remove `form-validation` styles

src/forms/form-group.scss

+2-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@
7070
}
7171

7272
label {
73-
position: relative;
73+
// fix for chrome bug, see https://github.com/github/github/issues/53931
74+
position: static;
7475
}
7576

7677
&.flattened dt, // TODO: Deprecate

src/forms/form-validation.scss

-265
This file was deleted.

src/forms/index.scss

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
@import './form-control.scss';
33
@import './form-select.scss';
44
@import './form-group.scss';
5-
@import './form-validation.scss';
65
@import './input-group.scss';
76
@import './radio-group.scss';
87
// new pvc components

0 commit comments

Comments
 (0)