Skip to content

Commit 4c012b9

Browse files
committed
chore: fix eslint warnings
1 parent e650fee commit 4c012b9

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

packages/dynamic-list-element/src/define.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
/* eslint-disable-next-line eslint-comments/no-use */
2+
/* eslint-disable ssr-friendly/no-dom-globals-in-module-scope */
3+
14
import {DynamicListElement} from './dynamic-list-element'
25
import {DynamicListItemElement} from './dynamic-list-item-element'
36
import {DynamicListTriggerElement} from './dynamic-list-trigger-element'

packages/dynamic-list-element/src/dynamic-list-element.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1+
/* eslint-disable-next-line eslint-comments/no-use */
2+
/* eslint-disable ssr-friendly/no-dom-globals-in-module-scope */
3+
14
const template = document.createElement('template')
5+
26
template.innerHTML = `
37
<style>
48
:host {
@@ -111,7 +115,7 @@ class DynamicListElement extends HTMLElement {
111115
})
112116
this.observer.observe(this)
113117

114-
triggerElement?.addEventListener('click', this.onTriggerClick)
118+
triggerElement.addEventListener('click', this.onTriggerClick)
115119
window.addEventListener('click', this.onClick)
116120
window.addEventListener('keydown', this.onKeyDown)
117121
}

packages/react/src/DynamicList/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import {DynamicListElement, DynamicListItemElement, DynamicListTriggerElement} from '@primer/dynamic-list-element'
21
import React from 'react'
2+
import type {DynamicListElement, DynamicListItemElement, DynamicListTriggerElement} from '@primer/dynamic-list-element'
33

44
type CustomElementAttributes<I> = React.DetailedHTMLProps<React.HTMLAttributes<I>, I> &
55
ElementProps<I> & {
@@ -12,6 +12,7 @@ type DynamicListItemAttributes = CustomElementAttributes<DynamicListItemElement>
1212
type DynamicListTriggerAttributes = CustomElementAttributes<DynamicListTriggerElement>
1313

1414
declare global {
15+
// eslint-disable-next-line @typescript-eslint/no-namespace
1516
namespace JSX {
1617
interface IntrinsicElements {
1718
'dynamic-list': DynamicListAttributes

0 commit comments

Comments
 (0)