Skip to content

Commit 568be84

Browse files
authored
Merge pull request #3130 from PiyushChandra17/piyush/fix-semantic-HTML
fix semantic HTML
2 parents 6086513 + ed88fd6 commit 568be84

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

client/modules/IDE/components/Editor/MobileEditor.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export const EditorContainer = styled.div`
99
transform: ${(props) =>
1010
props.expanded ? 'translateX(50%)' : 'translateX(0)'};
1111
12-
> header {
12+
> div {
1313
display: flex;
1414
${prop('MobilePanel.secondary')}
1515
> span {

client/modules/IDE/components/Editor/index.jsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@ class Editor extends React.Component {
513513
{(matches) =>
514514
matches ? (
515515
<section className={editorSectionClass}>
516-
<header className="editor__header">
516+
<div className="editor__header">
517517
<button
518518
aria-label={this.props.t('Editor.OpenSketchARIA')}
519519
className="sidebar__contract"
@@ -538,7 +538,7 @@ class Editor extends React.Component {
538538
</span>
539539
<Timer />
540540
</div>
541-
</header>
541+
</div>
542542
<article
543543
ref={(element) => {
544544
this.codemirrorContainer = element;
@@ -555,7 +555,7 @@ class Editor extends React.Component {
555555
</section>
556556
) : (
557557
<EditorContainer expanded={this.props.isExpanded}>
558-
<header>
558+
<>
559559
<IconButton
560560
onClick={this.props.expandSidebar}
561561
icon={FolderIcon}
@@ -564,7 +564,7 @@ class Editor extends React.Component {
564564
{this.props.file.name}
565565
<UnsavedChangesIndicator />
566566
</span>
567-
</header>
567+
</>
568568
<section>
569569
<EditorHolder
570570
ref={(element) => {

client/modules/IDE/components/Header/Nav.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ const UnauthenticatedUserMenu = () => {
270270
</span>
271271
</Link>
272272
</li>
273-
<span className="nav__item-or">{t('Nav.LoginOr')}</span>
273+
<li className="nav__item-or">{t('Nav.LoginOr')}</li>
274274
<li className="nav__item">
275275
<Link to="/signup" className="nav__auth-button">
276276
<span className="nav__item-header" title="SignUp">

client/modules/IDE/components/Header/index.jsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ const Header = (props) => {
1212
const isMobile = useIsMobile();
1313

1414
return (
15-
<header>
15+
<>
1616
<Nav />
1717
{!isMobile && (
1818
<Toolbar syncFileContent={props.syncFileContent} key={project.id} />
1919
)}
20-
</header>
20+
</>
2121
);
2222
};
2323

0 commit comments

Comments
 (0)