deleteProject controller tests

Author: andrewn

server/controllers/__mocks__/aws.controller.js

@@ -0,0 +1,5 @@
+export const getObjectKey = jest.mock();
+export const deleteObjectsFromS3 = jest.fn();
+export const signS3 = jest.fn();
+export const copyObjectInS3 = jest.fn();
+export const listObjectsInS3ForUser = jest.fn();

server/controllers/project.controller.js

@@ -2,19 +2,18 @@ import archiver from 'archiver';
 import format from 'date-fns/format';
 import isUrl from 'is-url';
 import jsdom, { serializeDocument } from 'jsdom';
-import isBefore from 'date-fns/is_before';
 import isAfter from 'date-fns/is_after';
 import request from 'request';
 import slugify from 'slugify';
 import Project from '../models/project';
 import User from '../models/user';
 import { resolvePathToFile } from '../utils/filePath';
 import generateFileSystemSafeName from '../utils/generateFileSystemSafeName';
-import { deleteObjectsFromS3, getObjectKey } from './aws.controller';
 import { toApi as toApiProjectObject } from '../domain-objects/Project';
 import createApplicationErrorClass from '../utils/createApplicationErrorClass';
 
 export { default as createProject, apiCreateProject } from './project.controller/createProject';
+export { default as deleteProject } from './project.controller/deleteProject';
 
 const UserNotFoundError = createApplicationErrorClass('UserNotFoundError');
 
@@ -88,36 +87,7 @@ export function getProject(req, res) {
     });
 }
 
-function deleteFilesFromS3(files) {
-  deleteObjectsFromS3(files.filter((file) => {
-    if (file.url) {
-      if (!process.env.S3_DATE || (
-        process.env.S3_DATE &&
-        isBefore(new Date(process.env.S3_DATE), new Date(file.createdAt)))) {
-        return true;
-      }
-    }
-    return false;
-  })
-    .map(file => getObjectKey(file.url)));
-}
 
-export function deleteProject(req, res) {
-  Project.findById(req.params.project_id, (findProjectErr, project) => {
-    if (!project.user.equals(req.user._id)) {
-      res.status(403).json({ success: false, message: 'Authenticated user does not match owner of project.' });
-      return;
-    }
-    deleteFilesFromS3(project.files);
-    project.remove((removeProjectError) => {
-      if (removeProjectError) {
-        res.status(404).send({ message: 'Project with that id does not exist' });
-        return;
-      }
-      res.json({ success: true });
-    });
-  });
-}
 
 export function getProjectsForUserId(userId) {
   return new Promise((resolve, reject) => {
@@ -239,7 +209,6 @@ export function apiGetProjectsForUser(req, res) {
   }
 }
 
-
 export function projectExists(projectId, callback) {
   Project.findById(projectId, (err, project) => (
     project ? callback(true) : callback(false)

server/controllers/project.controller/__test__/deleteProject.test.js

@@ -0,0 +1,115 @@
+/**
+ * @jest-environment node
+ */
+import { Request, Response } from 'jest-express';
+
+import Project, { createMock, createInstanceMock } from '../../../models/project';
+import User from '../../../models/user';
+import deleteProject from '../../project.controller/deleteProject';
+import { deleteObjectsFromS3 } from '../../aws.controller';
+
+
+jest.mock('../../../models/project');
+jest.mock('../../aws.controller');
+
+describe('project.controller', () => {
+  describe('deleteProject()', () => {
+    let ProjectMock;
+    let ProjectInstanceMock;
+
+    beforeEach(() => {
+      ProjectMock = createMock();
+      ProjectInstanceMock = createInstanceMock();
+    });
+
+    afterEach(() => {
+      ProjectMock.restore();
+      ProjectInstanceMock.restore();
+    });
+
+    it('returns 403 if project is not owned by authenticated user', (done) => {
+      const user = new User();
+      const project = new Project();
+      project.user = user;
+
+      const request = new Request();
+      request.setParams({ project_id: project._id });
+      request.user = { _id: 'abc123' };
+
+      const response = new Response();
+
+      ProjectMock
+        .expects('findById')
+        .resolves(project);
+
+      const promise = deleteProject(request, response);
+
+      function expectations() {
+        expect(response.status).toHaveBeenCalledWith(403);
+        expect(response.json).toHaveBeenCalledWith({ success: false, message: 'Authenticated user does not match owner of project' });
+
+        done();
+      }
+
+      promise.then(expectations, expectations).catch(expectations);
+    });
+
+    it('returns 404 if project does not exist', (done) => {
+      const user = new User();
+      const project = new Project();
+      project.user = user;
+
+      const request = new Request();
+      request.setParams({ project_id: project._id });
+      request.user = { _id: 'abc123' };
+
+      const response = new Response();
+
+      ProjectMock
+        .expects('findById')
+        .resolves(null);
+
+      const promise = deleteProject(request, response);
+
+      function expectations() {
+        expect(response.status).toHaveBeenCalledWith(404);
+        expect(response.json).toHaveBeenCalledWith({ success: false, message: 'Project with that id does not exist' });
+
+        done();
+      }
+
+      promise.then(expectations, expectations).catch(expectations);
+    });
+
+    it('deletes project and dependent files from S3 ', (done) => {
+      const user = new User();
+      const project = new Project();
+      project.user = user;
+
+      const request = new Request();
+      request.setParams({ project_id: project._id });
+      request.user = { _id: user._id };
+
+      const response = new Response();
+
+      ProjectMock
+        .expects('findById')
+        .resolves(project);
+
+      ProjectInstanceMock.expects('remove')
+        .yields();
+
+      const promise = deleteProject(request, response);
+
+      function expectations() {
+        expect(response.status).toHaveBeenCalledWith(200);
+        expect(response.json).toHaveBeenCalledWith({ success: true });
+        expect(deleteObjectsFromS3).toHaveBeenCalled();
+
+        done();
+      }
+
+      promise.then(expectations, expectations).catch(expectations);
+    });
+  });
+});

server/controllers/project.controller/deleteProject.js

@@ -0,0 +1,57 @@
+import isBefore from 'date-fns/is_before';
+import Project from '../../models/project';
+import { deleteObjectsFromS3, getObjectKey } from '../aws.controller';
+import createApplicationErrorClass from '../../utils/createApplicationErrorClass';
+
+const ProjectDeletionError = createApplicationErrorClass('ProjectDeletionError');
+
+function deleteFilesFromS3(files) {
+  deleteObjectsFromS3(files.filter((file) => {
+    if (file.url) {
+      if (!process.env.S3_DATE || (
+        process.env.S3_DATE &&
+        isBefore(new Date(process.env.S3_DATE), new Date(file.createdAt)))) {
+        return true;
+      }
+    }
+    return false;
+  })
+    .map(file => getObjectKey(file.url)));
+}
+
+export default function deleteProject(req, res) {
+  function sendFailure(error) {
+    res.status(error.code).json({ success: false, message: error.message });
+  }
+
+  function sendProjectNotFound() {
+    sendFailure(new ProjectDeletionError('Project with that id does not exist', { code: 404 }));
+  }
+
+  function handleProjectDeletion(project) {
+    if (project == null) {
+      sendProjectNotFound();
+      return;
+    }
+
+    if (!project.user.equals(req.user._id)) {
+      sendFailure(new ProjectDeletionError('Authenticated user does not match owner of project', { code: 403 }));
+      return;
+    }
+
+    deleteFilesFromS3(project.files);
+
+    project.remove((removeProjectError) => {
+      if (removeProjectError) {
+        sendProjectNotFound();
+        return;
+      }
+
+      res.status(200).json({ success: true });
+    });
+  }
+
+  return Project.findById(req.params.project_id)
+    .then(handleProjectDeletion)
+    .catch(sendFailure);
+}

server/models/__mocks__/project.js

@@ -21,6 +21,11 @@ export function createInstanceMock() {
     configurable: true,
   });
 
+  Object.defineProperty(Project.prototype, 'remove', {
+    value: Project.prototype.remove,
+    configurable: true,
+  });
+
   return sinon.mock(Project.prototype);
 }