Skip to content

implements vim mode #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

juscuzryancan
Copy link

@juscuzryancan juscuzryancan commented Aug 10, 2023

Fixes #1982

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Aug 10, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@lindapaiste
Copy link
Collaborator

If the user has enabled the Vim keymap, then there are a bunch of shortcuts that we are displaying in the UI would which be inaccurate, right? I don't know which of these are specific to the current sublime keymap but we have a bunch of shortcuts displayed in the KeyboardShortcutModal and in various nav menus. If a lot of those are impacted then maybe we need some sort of centralized utility for looking up the current command so that we don't have to have a million ternaries everywhere.

I'm also thinking about how we would display this in the preferences because I'm concerned that "Vim Mode: On / Off" is not intuitive if the user doesn't know what Vim is. Maybe some sort of explanatory tooltip would suffice. I'm pondering if "Keyboard Shortcuts: Sublime / Vim" is clearer. My concern is that someone might inadvertently turn Vim Mode on and then be really confused as to why the keyboard shortcuts that they are used to don't do anything.

@raclim raclim added the Closing Soon Will be closed in 7 days due to inactivity or resoltuion label Jan 16, 2024
@raclim
Copy link
Collaborator

raclim commented Jan 16, 2024

Since it's been a while since this PR has been updated, I've marked it with a "closing soon" label, which signifies that this PR will be closed in 10 days. Please feel free to revisit this to make any further updates or indicate that you would like to keep this open!

@juscuzryancan
Copy link
Author

@raclim I would like to keep this open and I will provide updates soon

@griffinwalker
Copy link

yes please

@raclim raclim added Feature Request Proposal for adding a new functionality Area:Editor For CodeMirror-related features and removed Closing Soon Will be closed in 7 days due to inactivity or resoltuion labels Jan 25, 2024
@juscuzryancan
Copy link
Author

Reopening in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Editor For CodeMirror-related features Feature Request Proposal for adding a new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Vim Mode
4 participants