-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added folder icons #2906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added folder icons #2906
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
@raclim I wonder what your thoughts are on using the @Anubhav-Vashishtha This PR looks generally good. We may want to make some small tweaks to the alignment and margin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I don't have any strong preferences here and would be down to use This might be better to pinpoint in the associated issue (#2881) or in a new one, but while I was testing this PR I realized something about the folder icons felt a little unfamiliar for me. I think it's because I'm accustomed to usually seeing chevron arrows when toggling a folder within a code editor. I do think the current icons we're using can be confusing. I'm wondering if maybe instead of changing the folder icon, it would be better to change the icon we're using to indicate options? Maybe something like this image (pulled from Glitch)? ![]() What I'm proposing is definitely a separate issue though (and would require a much bigger change), and I do also feel that the folder icon here works perfectly fine as well! I'm wondering if folks here have thoughts on what might be better? |
@raclim Yup got your point and currently working on it❤️ . I find your idea about arrows bit better and more intuitive Thanks buddy |
@raclim Take a look ✨ |
@raclim I think that using Open/Close folder icon will be more intuitive instead of using directional arrows because the folder icons are widely recognized as a symbol for organizing and categorizing content. And the open/close folder icons provide a simple and straightforward visual cue, making it easy for users to understand. Also as we are using file icon for the files it would make more sense to use folder icons to maintain the web app's consistency. |
Ahhh I don't think so .... Look brother the arrow points down showing all the files in the folder but after we close the it just point toward the folder name and there is another problem if we have let's say four folders inside one folder and we open this folder so now on screen we will see five folder icon (one open and 4 closed ) which is not a good UI and led to confusion |
Hey @Anubhav-Vashishtha, I understand your considerations regarding the use of directional arrows for folders. Your point about arrows indicating the direction of expansion is valid, and I understand your concern about the potential visual clutter caused by having multiple close folders among open ones.
These are my thoughts, let me know what you think about it. |
Since it's been a while since this PR was submitted, some of its contents have fallen quite out of sync with the current develop branch so I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to reopen this PR with any updates or check out our other issues! |
Fixes #2881
Changes:
Replace Directional arrows and Added folder icon to the side bar to make user experiences better
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123