Skip to content

translated functions of reference page to hindi #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

translated functions of reference page to hindi #1349

wants to merge 6 commits into from

Conversation

Manishkumar62
Copy link

@Manishkumar62 Manishkumar62 commented Apr 2, 2023

Fixes #1262

Changes:
I have done the translation all the function's inside page from english to hindi as told in this issue number

Screenshots of the change:
Screenshot (563)
Screenshot (564)

@Manishkumar62
Copy link
Author

@Divyansh013 , @limzykenneth guyz can you plz tell me why this pr is taking so much time to merge,
is their anything gone wrong with this translation code?
if yes then plz tell me, i will be happy to go with the problem

1 similar comment
@Manishkumar62
Copy link
Author

@Divyansh013 , @limzykenneth guyz can you plz tell me why this pr is taking so much time to merge,
is their anything gone wrong with this translation code?
if yes then plz tell me, i will be happy to go with the problem

@limzykenneth
Copy link
Member

@Manishkumar62 I just noticed from your screenshot that you translated the function names itself into Hindi? I don't think that is the original intention of the related issue. Function name should not be translated as the Javascript written are not translated (and should not be) and would cause quite a bit of confusion.

@limzykenneth
Copy link
Member

Or I might be misunderstanding, but in any case concentrating all 2000+ changes in one commit makes things very hard to review. In the future it would be better to split things up into smaller but more numerous commits so that we can sample and view changes more easily. Tagging translation stewards to have a look at this @adarrssh, @Divyansh013, @deepchauhan, @SarveshLimaye

@Manishkumar62
Copy link
Author

hi @limzykenneth will you going to merge or not?

@limzykenneth
Copy link
Member

Hi @Manishkumar62, translations should be reviewed by a translation steward before it can be merged. I'm not familiar with the language so I can't do the review. Do be patient as most contributors have very different availability to work on this. Thanks.

@adarrssh
Copy link
Contributor

Hey @Manishkumar62 sorry for responding late and thanks for your contribution. This is 7000+ lines of changes so give me some time to review it.

@adarrssh
Copy link
Contributor

Hey @Manishkumar62, The word "instance" can be translated to Hindi as "उदाहरण" or "इंस्टेंस" depending on the context.

  • "उदाहरण" means an example or sample etc
  • "इंस्टेंस" is just the literal translation of the word "instance" in Hindi.

I think in the programming context the more accurate Hindi translation of this line This is the p5 instance constructor. would be "यह p5 इंस्टेंस कंस्ट्रक्टर है।". It's better to just use the "इंस्टेंस" (instance) word as it is and not translate it "उदाहरण"(example).

What do you think?

@adarrssh
Copy link
Contributor

Hi @limzykenneth and @Manishkumar62, I have a request to make. Could we split the current issue into 7 separate PRs, each containing approximately 1000 lines of code? This will make it easier for me to review and merge into production. The total lines of code will be over 7000, so breaking it down into smaller PRs will simplify the process. Thank you.

@limzykenneth
Copy link
Member

limzykenneth commented Sep 30, 2023

@adarrssh @Manishkumar62 I would suggest either breaking this up into smaller PRs or even just individual smaller commits instead of one big commit that contains too many changes as well. As @adarrssh noted, I also concur that a big PR with over 7000 lines of changes is very difficult to review.

@Manishkumar62 If you need help with splitting this up, feel free to let me know.

@Manishkumar62
Copy link
Author

@limzykenneth and @adarrssh thanks for replying and sure I will split the PR into smaller 7 PRs. @limzykenneth i really need some guidance to split the PR in smaller ones. Can you please tell me what processes/steps should i follow now bcoz now when i look into the file i see the code is in hindi, do i have to revert back from that commit or is there any short process that can split the commit. If you have any type of resource or any youtube vedio that can also be very helpful.
Thank you!

@limzykenneth
Copy link
Member

Sure @Manishkumar62, the way I would do it would be to start with git reset HEAD~ which will roll back the latest commit (9cf19d89942f942e5d486f59fd933c32b3736b89) in git, this will still keep the changes around but they will be in an uncommitted state (git status should say only the hi.json file is in a modified state).

Once that's done you can start committing chunks of the changes by using git add -p which will give you an interactive prompt that can help you select chunks you want to commit, you can read more about how it works in the documentation or you can search for a video explaining how it works as well.

When you have figured out how git add -p works, I would suggest adding changes to one section, eg. a group of about 10 related functions, at a time then commit it. Then do git add -p again, adding another section, commit, and repeat.

Let me know if this makes sense to you (or not).

@Manishkumar62
Copy link
Author

Thank you @limzykenneth for providing such a deep guidence to me. I have some placement releted stuff in my college. I will definitely do your suggested steps in a week. Thank you!

@Manishkumar62 Manishkumar62 closed this by deleting the head repository Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation of Reference Page in Hindi
3 participants