-
-
Notifications
You must be signed in to change notification settings - Fork 476
translated functions of reference page to hindi #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Divyansh013 , @limzykenneth guyz can you plz tell me why this pr is taking so much time to merge, |
1 similar comment
@Divyansh013 , @limzykenneth guyz can you plz tell me why this pr is taking so much time to merge, |
@Manishkumar62 I just noticed from your screenshot that you translated the function names itself into Hindi? I don't think that is the original intention of the related issue. Function name should not be translated as the Javascript written are not translated (and should not be) and would cause quite a bit of confusion. |
Or I might be misunderstanding, but in any case concentrating all 2000+ changes in one commit makes things very hard to review. In the future it would be better to split things up into smaller but more numerous commits so that we can sample and view changes more easily. Tagging translation stewards to have a look at this @adarrssh, @Divyansh013, @deepchauhan, @SarveshLimaye |
hi @limzykenneth will you going to merge or not? |
Hi @Manishkumar62, translations should be reviewed by a translation steward before it can be merged. I'm not familiar with the language so I can't do the review. Do be patient as most contributors have very different availability to work on this. Thanks. |
Hey @Manishkumar62 sorry for responding late and thanks for your contribution. This is 7000+ lines of changes so give me some time to review it. |
Hey @Manishkumar62, The word "instance" can be translated to Hindi as "उदाहरण" or "इंस्टेंस" depending on the context.
I think in the programming context the more accurate Hindi translation of this line What do you think? |
Hi @limzykenneth and @Manishkumar62, I have a request to make. Could we split the current issue into 7 separate PRs, each containing approximately 1000 lines of code? This will make it easier for me to review and merge into production. The total lines of code will be over 7000, so breaking it down into smaller PRs will simplify the process. Thank you. |
@adarrssh @Manishkumar62 I would suggest either breaking this up into smaller PRs or even just individual smaller commits instead of one big commit that contains too many changes as well. As @adarrssh noted, I also concur that a big PR with over 7000 lines of changes is very difficult to review. @Manishkumar62 If you need help with splitting this up, feel free to let me know. |
@limzykenneth and @adarrssh thanks for replying and sure I will split the PR into smaller 7 PRs. @limzykenneth i really need some guidance to split the PR in smaller ones. Can you please tell me what processes/steps should i follow now bcoz now when i look into the file i see the code is in hindi, do i have to revert back from that commit or is there any short process that can split the commit. If you have any type of resource or any youtube vedio that can also be very helpful. |
Sure @Manishkumar62, the way I would do it would be to start with Once that's done you can start committing chunks of the changes by using When you have figured out how Let me know if this makes sense to you (or not). |
Thank you @limzykenneth for providing such a deep guidence to me. I have some placement releted stuff in my college. I will definitely do your suggested steps in a week. Thank you! |
Fixes #1262
Changes:
I have done the translation all the function's inside page from english to hindi as told in this issue number
Screenshots of the change:

