Add new tests for validateParameters + fix typos

Author: akshay-99

src/core/error_helpers.js

@@ -313,7 +313,7 @@ if (typeof IS_MINIFIED !== 'undefined') {
   //                - seen: true
   // seen: true signifies that this argument was also seen as the last
   // argument in a call. Now in the second run of the sketch, it would traverse
-  // the existing tree and see get seen: true, i.e this sequence was seen
+  // the existing tree and see seen: true, i.e this sequence was seen
   // before and so scoring can be skipped. This also prevents logging multiple
   // validation messages for the same thing.
 
@@ -771,6 +771,11 @@ if (typeof IS_MINIFIED !== 'undefined') {
     }
   };
 
+  // allowing access to argumentTree for testing
+  p5._getValidateParamsArgTree = function getValidateParamsArgTree() {
+    return argumentTree;
+  };
+
   /**
    * Validates parameters
    * param  {String}               func    the name of the function

test/unit/core/error_helpers.js

@@ -123,6 +123,76 @@ suite('Error Helpers', function() {
     }
   );
 
+  suite('validateParameters: argument tree', function() {
+    // should not throw a validation error for the same kind of wrong args
+    // more than once. This prevents repetetive validation logs for a
+    // function that is called in a loop or draw()
+    testUnMinified(
+      'no repeated validation error for the same wrong arguments',
+      function() {
+        assert.validationError(function() {
+          myp5.color();
+        });
+
+        assert.doesNotThrow(
+          function() {
+            myp5.color(); // Same type of wrong arguments as above
+          },
+          p5.ValidationError,
+          'got unwanted ValidationError'
+        );
+      }
+    );
+
+    testUnMinified(
+      'should throw validation errors for different wrong args',
+      function() {
+        assert.validationError(function() {
+          myp5.color();
+        });
+
+        assert.validationError(function() {
+          myp5.color(false);
+        });
+      }
+    );
+
+    testUnMinified('arg tree is built properly', function() {
+      let myArgTree = p5._getValidateParamsArgTree();
+      myp5.random();
+      myp5.random(50);
+      myp5.random([50, 70, 10]);
+      assert.strictEqual(
+        myArgTree.random.seen,
+        true,
+        'tree built correctly for random()'
+      );
+      assert.strictEqual(
+        myArgTree.random.number.seen,
+        true,
+        'tree built correctly for random(min: Number)'
+      );
+      assert.strictEqual(
+        myArgTree.random.as.number.number.number.seen,
+        true,
+        'tree built correctly for random(choices: Array)'
+      );
+
+      let c = myp5.color(10);
+      myp5.alpha(c);
+      assert.strictEqual(
+        myArgTree.color.number.seen,
+        true,
+        'tree built correctly for color(gray: Number)'
+      );
+      assert.strictEqual(
+        myArgTree.alpha.Color.seen,
+        true,
+        'tree built correctly for alpha(color: p5.Color)'
+      );
+    });
+  });
+
   suite('validateParameters: multi-format', function() {
     test('color(): no friendly-err-msg', function() {
       assert.doesNotThrow(