Skip to content

Commit 07ef004

Browse files
committed
(#242) Wrap names in backticks when rendering to markdown
Updates the markdown templates to wrap many resource and value names in backticks to prevent emoji from being inadvertantly rendered when a resource name contains a namespace that happens to also be an emoji sequence on Github et. al.
1 parent a76dd4c commit 07ef004

File tree

7 files changed

+15
-15
lines changed

7 files changed

+15
-15
lines changed

lib/puppet-strings/markdown/templates/classes_and_defines.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
### <%= name %>
1+
### `<%= name %>`
22

33
<% if text -%>
44
<%= text %>
@@ -75,7 +75,7 @@ Options:
7575

7676
<% end -%>
7777
<% if defaults && defaults[param[:name]] -%>
78-
Default value: <%= value_string(defaults[param[:name]]) %>
78+
Default value: `<%= value_string(defaults[param[:name]]) %>`
7979

8080
<% end -%>
8181
<% end -%>

lib/puppet-strings/markdown/templates/data_type.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
### <%= name %>
1+
### `<%= name %>`
22

33
<% if text -%>
44
<%= text %>
@@ -79,7 +79,7 @@ Options:
7979

8080
<% end -%>
8181
<% if defaults && defaults[param[:name]] -%>
82-
Default value: <%= value_string(defaults[param[:name]]) %>
82+
Default value: `<%= value_string(defaults[param[:name]]) %>`
8383

8484
<% end -%>
8585
<% end -%>

lib/puppet-strings/markdown/templates/data_type_function.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
### <%= name %>
1+
### `<%= name %>`
22

33
#### `<%= signature %>`
44

lib/puppet-strings/markdown/templates/function.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
### <%= name %>
1+
### `<%= name %>`
22

33
Type: <%= type %>
44

lib/puppet-strings/markdown/templates/puppet_task.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
### <%= name %>
1+
### `<%= name %>`
22

33
<% if text -%>
44
<%= text %>

lib/puppet-strings/markdown/templates/resource_type.erb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
### <%= name %>
1+
### `<%= name %>`
22

33
<% if text -%>
44
<%= text %>
@@ -53,15 +53,15 @@ The following properties are available in the `<%= name %>` <%= @type %>.
5353
##### `<%= prop[:name] %>`
5454

5555
<% if prop[:values] -%>
56-
Valid values: <%= prop[:values].map { |value| value_string(value) }.join(', ') %>
56+
Valid values: `<%= prop[:values].map { |value| value_string(value) }.join('`, `') %>`
5757

5858
<% end -%>
5959
<% if prop[:isnamevar] -%>
6060
namevar
6161

6262
<% end -%>
6363
<% if prop[:aliases] -%>
64-
Aliases: <%= prop[:aliases].to_s.delete('{').delete('}') %>
64+
Aliases: `<%= prop[:aliases].to_s.delete('{').delete('}') %>`
6565

6666
<% end -%>
6767
<% if prop[:data_type] -%>
@@ -87,7 +87,7 @@ Options:
8787

8888
<% end -%>
8989
<% if prop[:default] -%>
90-
Default value: <%= prop[:default] %>
90+
Default value: `<%= prop[:default] %>`
9191

9292
<% end -%>
9393
<% end -%>
@@ -101,15 +101,15 @@ The following parameters are available in the `<%= name %>` <%= @type %>.
101101
##### `<%= param[:name] %>`
102102

103103
<% if param[:values] -%>
104-
Valid values: <%= param[:values].map { |value| value_string(value) }.join(', ') %>
104+
Valid values: `<%= param[:values].map { |value| value_string(value) }.join('`, `') %>`
105105

106106
<% end -%>
107107
<% if param[:isnamevar] -%>
108108
namevar
109109

110110
<% end -%>
111111
<% if param[:aliases] -%>
112-
Aliases: <%= param[:aliases].to_s.delete('{').delete('}') %>
112+
Aliases: `<%= param[:aliases].to_s.delete('{').delete('}') %>`
113113

114114
<% end -%>
115115
<% if param[:data_type] -%>
@@ -135,7 +135,7 @@ Options:
135135

136136
<% end -%>
137137
<% if param[:default] -%>
138-
Default value: <%= value_string(param[:default]) %>
138+
Default value: `<%= value_string(param[:default]) %>`
139139

140140
<% end -%>
141141
<% if param[:required_features] -%>

spec/unit/puppet-strings/markdown_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def parse_data_type_content
133133
end
134134

135135
it 'includes param default' do
136-
expect(output).to match(/default value: param2/i)
136+
expect(output).to match(/default value: `param2`/i)
137137
end
138138
end
139139

0 commit comments

Comments
 (0)